From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E08131282F for ; Sun, 12 Apr 2026 08:56:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775984199; cv=none; b=Egvb/P7R0RBrr/sFluC40fQg1qxpo1MwHlR/PKcggiF0gFTrUtqznw2ekML1Kp0RGTlAkHcZB2RJPWwP1W1WtcMK7aFFcqtfFPDBLRfszwbpDoglu8E8pqMN67rj9/D0J3McTbtugrw+xvBmPAe0boD7d5+Gc33Ob9Xay20vBls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775984199; c=relaxed/simple; bh=XZtsBYJ+xUzK/w66hhh7L4ep5/Nv3d9zyXSTiNiHtzQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nBob1VLEdl1atvMzGDs0etxC244oFJtMYX1AdWgnFihD+AU7zegupmZAjnW6yk8Pa0oXr+P+fvoPGSzBxbhbyptXAd3G69clAMaue5FC9LCNVY9Hh9qoIEcAOZoNYKmifZkdt++NpAeeKNnTcQmQ5owvfkSjLT7qbYWa0X7k/5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rmk25eS0; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rmk25eS0" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-482f454be5bso36434235e9.0 for ; Sun, 12 Apr 2026 01:56:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775984196; x=1776588996; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=; b=rmk25eS0pD3r1W6fBjCHCIGG+xosVecWiNg/3nfNyAKaxOqHC0aIxIp+bwKvPu9+1j fAU2vugkDHatrG3Fzq7V9jewKzPcvw41odvofwZkis7b1Y4DeW1IWegwg5QbXQj7kCio L+ztGdtDUlhH+iJPC48SIdv4mbiVxmA7Be8JQhGglK1VOqWIq1YR4dry10OotSVrXztE o4/62vmfM6KQrUkxwd24yP/lrxDf8HyZquUshVzt2ycEVPZUv3y2nMTj7GvueTw7R7E/ WKG3HtUgcwPCHxCI4T+H5u0NML0HalT4/vA4x/F5vuumDuC+b3YDtjggzfClJhOrbI7r R2bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775984196; x=1776588996; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=; b=R2Y61vNso52IF68TqWjJBvK/GWUam9ttjUP4i09awssn638durUMGRErUG197uA5Hq 7LjsJZ6R5E7rCDxVbM8TRHLy0u9/bKyeDjK/o7jYC1UhNQwchUG3jdPSq+bmAnqQkc3N Q7BNctkc54lXy8zJX8l4msZ4i4nBJfuwInpRpynnkALoKNPcsoq9b35q7SRezJLJXwt/ 2/LBpGaJiWzhW5YsqMVEl4dXdDVdJAz15Dtsm+JJzO8iqh0GfbOxA1Ju/ZZrcLMPiBEc 9YwpgtdTrVrsR3ELYSG8yz1qskr1K+zCKQT1AmAQEmTpeW/XxmgjGYkD+rIHq5eTTxlO uwTg== X-Forwarded-Encrypted: i=1; AJvYcCVFcf6jInRbiUFemeJFND8XUa9ZDSKlrn/GBrv7HOUU/vUDanzU4THDwORg7rBlPi9VEYJ7EPFM5jRk1hqARg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz7ZuF4oBSrwzQ75sLJXiaPKkmVwQWwtUmosdbfKiLneYXs4zB4 L3EauQns5oDvkfdgsqI1sPWxoXRh6UUQL4deONhRelCDDSmDwWrL3ect X-Gm-Gg: AeBDiesRytmLAEj8bqgj/abvoZDAi42NIlHWaQg7Dq2gNwk+cVr3lNBNsChXCZeujDL FMXbp1whJftJ13SbuWwG5xfSI7tqJhiI0gZI7dZLEXameykQyMs0oVevyzUyp0jPmdA4Pxb6O8b DAOlsBaBzthsSEtgDB+LVVUTLhvSbTyNTxrhzhqkgWMYGHYKD55ab7xfrqCHMHl1SNVoN/azJvr EGx5eHsDSBbBicoR0K+RlQDnFawq98rU4F8e2ss9vzHQHNH65ilP2uIeXoOwOK5nyAv4mNIIQsv y0BQVDDkIaJOv8CMBzvg//3X3ziDyf81/khYd5oib9/xt4SKgqDlRFd0nAwm/e1SBFdCxwz4Ogx bBlKWfriBYD0nBkqHPAtvTnJTpuJ1w8/RolHDDCwhs03XtbzgCYuAFvwjDd1+DQUmanggLuAeoD VmNAFHgNhIh9hAsWz2D0DKajey1a4MgxrrguycLmv9LYDpms2H7IkrdhYhJgZgQzGqOUyZkBXN0 9edbQ== X-Received: by 2002:a05:600c:698d:b0:487:22ad:403e with SMTP id 5b1f17b1804b1-488d6ac9ce5mr126951995e9.14.1775984195334; Sun, 12 Apr 2026 01:56:35 -0700 (PDT) Received: from localhost (brnt-04-b2-v4wan-170138-cust2432.vm7.cable.virginm.net. [94.175.9.129]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d532ed4dsm197923925e9.4.2026.04.12.01.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Apr 2026 01:56:34 -0700 (PDT) Date: Sun, 12 Apr 2026 09:56:33 +0100 From: Stafford Horne To: Thomas Gleixner Cc: LKML , Jonas Bonn , linux-openrisc@vger.kernel.org, Arnd Bergmann , x86@kernel.org, Lu Baolu , iommu@lists.linux.dev, Michael Grzeschik , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Herbert Xu , linux-crypto@vger.kernel.org, Vlastimil Babka , linux-mm@kvack.org, David Woodhouse , Bernie Thompson , linux-fbdev@vger.kernel.org, Theodore Tso , linux-ext4@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Thomas Sailer , linux-hams@vger.kernel.org, "Jason A. Donenfeld" , Richard Henderson , linux-alpha@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Huacai Chen , loongarch@lists.linux.dev, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Dinh Nguyen , Helge Deller , linux-parisc@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Paul Walmsley , linux-riscv@lists.infradead.org, Heiko Carstens , linux-s390@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: [patch 30/38] openrisc: Select ARCH_HAS_RANDOM_ENTROPY Message-ID: References: <20260410120044.031381086@kernel.org> <20260410120319.593798781@kernel.org> Precedence: bulk X-Mailing-List: linux-openrisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260410120319.593798781@kernel.org> On Fri, Apr 10, 2026 at 02:20:55PM +0200, Thomas Gleixner wrote: > The only remaining non-architecture usage of get_cycles() is to provide > random_get_entropy(). > > Switch openrisc over to the new scheme of selecting ARCH_HAS_RANDOM_ENTROPY > and providing random_get_entropy() in asm/random.h. > > Add 'asm/timex.h' includes to the relevant files, so the global include can > be removed once all architectures are converted over. > > Signed-off-by: Thomas Gleixner > Cc: Jonas Bonn > Cc: linux-openrisc@vger.kernel.org This looks good to me. Acked-by: Stafford Horne > --- > arch/openrisc/Kconfig | 1 + > arch/openrisc/include/asm/random.h | 12 ++++++++++++ > arch/openrisc/include/asm/timex.h | 5 ----- > arch/openrisc/lib/delay.c | 1 + > 4 files changed, 14 insertions(+), 5 deletions(-) > > --- a/arch/openrisc/Kconfig > +++ b/arch/openrisc/Kconfig > @@ -10,6 +10,7 @@ config OPENRISC > select ARCH_HAS_DELAY_TIMER > select ARCH_HAS_DMA_SET_UNCACHED > select ARCH_HAS_DMA_CLEAR_UNCACHED > + select ARCH_HAS_RANDOM_ENTROPY > select ARCH_HAS_SYNC_DMA_FOR_DEVICE > select GENERIC_BUILTIN_DTB > select COMMON_CLK > --- /dev/null > +++ b/arch/openrisc/include/asm/random.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > +#ifndef __ASM_OPENRISC_RANDOM_H > +#define __ASM_OPENRISC_RANDOM_H > + > +#include > + > +static inline unsigned long random_get_entropy(void) > +{ > + return get_cycles(); > +} > + > +#endif > --- a/arch/openrisc/include/asm/timex.h > +++ b/arch/openrisc/include/asm/timex.h > @@ -9,13 +9,9 @@ > * OpenRISC implementation: > * Copyright (C) 2010-2011 Jonas Bonn > */ > - > #ifndef __ASM_OPENRISC_TIMEX_H > #define __ASM_OPENRISC_TIMEX_H > > -#define get_cycles get_cycles > - > -#include > #include > #include > > @@ -23,6 +19,5 @@ static inline cycles_t get_cycles(void) > { > return mfspr(SPR_TTCR); > } > -#define get_cycles get_cycles > > #endif > --- a/arch/openrisc/lib/delay.c > +++ b/arch/openrisc/lib/delay.c > @@ -18,6 +18,7 @@ > #include > > #include > +#include > #include > > bool delay_read_timer(unsigned long *timer_value) > >