OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Xiang W <wxjstz@126.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 1/2] platform: ensure enough heap size with debug triggers extension
Date: Fri, 20 Sep 2024 13:33:23 +0800	[thread overview]
Message-ID: <1138805ae38b4d47b0a64bd6de374757d6501460.camel@126.com> (raw)
In-Reply-To: <20240916072516.628461-1-inochiama@gmail.com>

? 2024-09-16???? 15:25 +0800?Inochi Amaoto???
> DBTR introduce a big heap allocation to store hart state, this is
> allocated percpu and needs big space when CPU number is high.
> 
> Increase the percpu part to fix this problem, and decrease the
> fixed part to avoid too big heap size.
> 
> Fixes: 97f234f (lib: sbi: Introduce the SBI debug triggers extension support)
> Signed-off-by: Inochi Amaoto <inochiama@gmail.com>

LGTM

Reviewed-by: Xiang W <wxjstz@126.com>

> ---
> ?include/sbi/sbi_platform.h | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/sbi/sbi_platform.h b/include/sbi/sbi_platform.h
> index 7b3ac4b..d1c556c 100644
> --- a/include/sbi/sbi_platform.h
> +++ b/include/sbi/sbi_platform.h
> @@ -152,7 +152,7 @@ struct sbi_platform_operations {
> ?
> ?/** Platform default heap size */
> ?#define SBI_PLATFORM_DEFAULT_HEAP_SIZE(__num_hart)	\
> -					(0x8000 + 0x800 * (__num_hart))
> +					(0x4000 + 0x2000 * (__num_hart))
> ?
> ?/** Representation of a platform */
> ?struct sbi_platform {



  reply	other threads:[~2024-09-20  5:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  7:24 [PATCH 0/2] platform: improve heap size handle Inochi Amaoto
2024-09-16  7:25 ` [PATCH 1/2] platform: ensure enough heap size with debug triggers extension Inochi Amaoto
2024-09-20  5:33   ` Xiang W [this message]
2024-09-16  7:25 ` [PATCH 2/2] platform: introduce DT-based configurable heap size Inochi Amaoto
2024-09-20  5:33   ` Xiang W
2024-09-20  7:40     ` Inochi Amaoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138805ae38b4d47b0a64bd6de374757d6501460.camel@126.com \
    --to=wxjstz@126.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox