OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dong Du <ddnirvana1@gmail.com>
To: opensbi@lists.infradead.org
Subject: [PATCH] lib: sbi: Fix bug in strncmp function
Date: Tue, 27 Jul 2021 00:41:11 +0800	[thread overview]
Message-ID: <20210726164111.17320-1-ddnirvana1@gmail.com> (raw)

From: Dong Du <dd_nirvana@sjtu.edu.cn>

strncmp should return 0 when the count is 0.
Fix the issue in sbi_strncmp.

Signed-off-by: Dong Du <ddnirvana1@gmail.com>
---
 lib/sbi/sbi_string.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/sbi/sbi_string.c b/lib/sbi/sbi_string.c
index 7805ba4..f93ed5f 100644
--- a/lib/sbi/sbi_string.c
+++ b/lib/sbi/sbi_string.c
@@ -29,6 +29,9 @@ int sbi_strcmp(const char *a, const char *b)
 
 int sbi_strncmp(const char *a, const char *b, size_t count)
 {
+	if (!count)
+		return 0;
+
 	/* search first diff or end of string */
 	for (; count > 0 && *a == *b && *a != '\0'; a++, b++, count--)
 		;
-- 
2.31.1



             reply	other threads:[~2021-07-26 16:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 16:41 Dong Du [this message]
2021-07-27 16:15 ` [PATCH] lib: sbi: Fix bug in strncmp function Andreas Schwab
2021-07-28 16:16   ` 杜东
  -- strict thread matches above, loose matches on Subject: below --
2021-07-27  6:08 Dong Du

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210726164111.17320-1-ddnirvana1@gmail.com \
    --to=ddnirvana1@gmail.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox