From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 1/2] lib: utils/ipi: Fix size check in aclint_mswi_cold_init()
Date: Sun, 9 Jan 2022 20:50:35 +0530 [thread overview]
Message-ID: <20220109152036.28666-2-apatel@ventanamicro.com> (raw)
In-Reply-To: <20220109152036.28666-1-apatel@ventanamicro.com>
Currently, the ACLINT MSWI size check is forcing size to be at least
0x4000. This is inappropriate check because most systems will never
utilize full 16KB for a single ACLINT MSWI device so instead we should
check that ACLINT MSWI size is enough for on the associated HARTs.
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Reviewed-by: Dong Du <Dd_nirvana@sjtu.edu.cn>
---
lib/utils/ipi/aclint_mswi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/utils/ipi/aclint_mswi.c b/lib/utils/ipi/aclint_mswi.c
index a3de2f5..832e223 100644
--- a/lib/utils/ipi/aclint_mswi.c
+++ b/lib/utils/ipi/aclint_mswi.c
@@ -74,7 +74,7 @@ int aclint_mswi_cold_init(struct aclint_mswi_data *mswi)
/* Sanity checks */
if (!mswi || (mswi->addr & (ACLINT_MSWI_ALIGN - 1)) ||
- (mswi->size < ACLINT_MSWI_SIZE) ||
+ (mswi->size < (mswi->hart_count * sizeof(u32))) ||
(mswi->first_hartid >= SBI_HARTMASK_MAX_BITS) ||
(mswi->hart_count > ACLINT_MSWI_MAX_HARTS))
return SBI_EINVAL;
--
2.25.1
next prev parent reply other threads:[~2022-01-09 15:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-09 15:20 [PATCH v2 0/2] Misc driver improvements Anup Patel
2022-01-09 15:20 ` Anup Patel [this message]
2022-01-09 22:13 ` [PATCH v2 1/2] lib: utils/ipi: Fix size check in aclint_mswi_cold_init() Alistair Francis
2022-01-11 12:48 ` Anup Patel
2022-01-09 15:20 ` [PATCH v2 2/2] lib: utils/sys: Extend HTIF library to allow custom base address Anup Patel
2022-01-10 22:31 ` Atish Patra
2022-01-11 12:49 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220109152036.28666-2-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox