* [PATCH] docs/firmware: update the document
@ 2022-10-20 14:41 pyjmstr
2022-10-21 1:55 ` Bin Meng
2022-10-23 5:18 ` Anup Patel
0 siblings, 2 replies; 3+ messages in thread
From: pyjmstr @ 2022-10-20 14:41 UTC (permalink / raw)
To: opensbi
From: Yangjie Zhang <pyjmstr@gmail.com>
Since
commit 9c07c513aa9b ("firmware:Remove FW_PAYLOAD_FDT_PATH compile-time option"),
the section where FDT would be embedded in has changed from *.text* to *.rodata*,
but some places in fw_payload.md and fw.md are still *.text*.
This patch updates the document.
Signed-off-by: Yangjie Zhang <pyjmstr@gmail.com>
---
docs/firmware/fw.md | 2 +-
docs/firmware/fw_payload.md | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/firmware/fw.md b/docs/firmware/fw.md
index 5a67848..18faaa9 100644
--- a/docs/firmware/fw.md
+++ b/docs/firmware/fw.md
@@ -53,7 +53,7 @@ the booting stage to follow OpenSBI firmware.
A *FW_PAYLOAD* firmware is also useful for cases where the booting stage prior
to OpenSBI firmware does not pass a *flattened device tree (FDT file)*. In such
case, a *FW_PAYLOAD* firmware allows embedding a flattened device tree in the
-.text section of the final firmware.
+.rodata section of the final firmware.
Firmware Configuration and Compilation
--------------------------------------
diff --git a/docs/firmware/fw_payload.md b/docs/firmware/fw_payload.md
index 3bb918f..3d50ddc 100644
--- a/docs/firmware/fw_payload.md
+++ b/docs/firmware/fw_payload.md
@@ -12,7 +12,7 @@ firmware and the booting stage to follow OpenSBI firmware.
A *FW_PAYLOAD* firmware is also useful for cases where the booting stage prior
to the OpenSBI firmware does not pass a *flattened device tree (FDT file)*. In
such a case, a *FW_PAYLOAD* firmware allows embedding a flattened device tree
-in the .text section of the final firmware.
+in the .rodata section of the final firmware.
Enabling *FW_PAYLOAD* compilation
---------------------------------
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] docs/firmware: update the document
2022-10-20 14:41 [PATCH] docs/firmware: update the document pyjmstr
@ 2022-10-21 1:55 ` Bin Meng
2022-10-23 5:18 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Bin Meng @ 2022-10-21 1:55 UTC (permalink / raw)
To: opensbi
On Thu, Oct 20, 2022 at 10:42 PM <pyjmstr@gmail.com> wrote:
>
> From: Yangjie Zhang <pyjmstr@gmail.com>
>
> Since
> commit 9c07c513aa9b ("firmware:Remove FW_PAYLOAD_FDT_PATH compile-time option"),
> the section where FDT would be embedded in has changed from *.text* to *.rodata*,
> but some places in fw_payload.md and fw.md are still *.text*.
> This patch updates the document.
>
> Signed-off-by: Yangjie Zhang <pyjmstr@gmail.com>
> ---
> docs/firmware/fw.md | 2 +-
> docs/firmware/fw_payload.md | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] docs/firmware: update the document
2022-10-20 14:41 [PATCH] docs/firmware: update the document pyjmstr
2022-10-21 1:55 ` Bin Meng
@ 2022-10-23 5:18 ` Anup Patel
1 sibling, 0 replies; 3+ messages in thread
From: Anup Patel @ 2022-10-23 5:18 UTC (permalink / raw)
To: opensbi
On Thu, Oct 20, 2022 at 8:11 PM <pyjmstr@gmail.com> wrote:
>
> From: Yangjie Zhang <pyjmstr@gmail.com>
>
> Since
> commit 9c07c513aa9b ("firmware:Remove FW_PAYLOAD_FDT_PATH compile-time option"),
> the section where FDT would be embedded in has changed from *.text* to *.rodata*,
> but some places in fw_payload.md and fw.md are still *.text*.
> This patch updates the document.
>
> Signed-off-by: Yangjie Zhang <pyjmstr@gmail.com>
Looks good to me.
Reviewed-by: Anup Patel <anup@brainfault.org>
Applied this patch to the riscv/opensbi repo.
Thanks,
Anup
> ---
> docs/firmware/fw.md | 2 +-
> docs/firmware/fw_payload.md | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/firmware/fw.md b/docs/firmware/fw.md
> index 5a67848..18faaa9 100644
> --- a/docs/firmware/fw.md
> +++ b/docs/firmware/fw.md
> @@ -53,7 +53,7 @@ the booting stage to follow OpenSBI firmware.
> A *FW_PAYLOAD* firmware is also useful for cases where the booting stage prior
> to OpenSBI firmware does not pass a *flattened device tree (FDT file)*. In such
> case, a *FW_PAYLOAD* firmware allows embedding a flattened device tree in the
> -.text section of the final firmware.
> +.rodata section of the final firmware.
>
> Firmware Configuration and Compilation
> --------------------------------------
> diff --git a/docs/firmware/fw_payload.md b/docs/firmware/fw_payload.md
> index 3bb918f..3d50ddc 100644
> --- a/docs/firmware/fw_payload.md
> +++ b/docs/firmware/fw_payload.md
> @@ -12,7 +12,7 @@ firmware and the booting stage to follow OpenSBI firmware.
> A *FW_PAYLOAD* firmware is also useful for cases where the booting stage prior
> to the OpenSBI firmware does not pass a *flattened device tree (FDT file)*. In
> such a case, a *FW_PAYLOAD* firmware allows embedding a flattened device tree
> -in the .text section of the final firmware.
> +in the .rodata section of the final firmware.
>
> Enabling *FW_PAYLOAD* compilation
> ---------------------------------
> --
> 2.34.1
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-23 5:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-20 14:41 [PATCH] docs/firmware: update the document pyjmstr
2022-10-21 1:55 ` Bin Meng
2022-10-23 5:18 ` Anup Patel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox