From mboxrd@z Thu Jan 1 00:00:00 1970 From: Conor Dooley Date: Fri, 14 Jul 2023 13:28:50 +0100 Subject: Boot failure after QEMU's upgrade to OpenSBI v1.3 (was Re: [PATCH for-8.2 6/7] target/riscv: add 'max' CPU type) In-Reply-To: <20230714-reoccur-confined-4b37494b1201@spud> References: <20230712-stench-happiness-40c2ea831257@spud> <3e9b5be8-d3ca-3a17-bef9-4a6a5bdc0ad0@ventanamicro.com> <20230712-tulip-replica-0322e71c3e81@spud> <744cbde6-7ce5-c327-3c5a-3858e994cc39@ventanamicro.com> <20230712-superhero-rabid-578605f52927@spud> <5dd3366d-13ba-c7fb-554f-549d97e7d4f9@ventanamicro.com> <20230712-fancied-aviator-270f51166407@spud> <20230713-craziness-lankiness-8aec3db24993@spud> <20230714-reoccur-confined-4b37494b1201@spud> Message-ID: <20230714-hash-handwrite-339817b93ba1@spud> List-Id: To: opensbi@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jul 14, 2023 at 11:19:34AM +0100, Conor Dooley wrote: > On Fri, Jul 14, 2023 at 10:00:19AM +0530, Anup Patel wrote: > > > > > OpenSBI v1.3 > > > > ____ _____ ____ _____ > > > > / __ \ / ____| _ \_ _| > > > > | | | |_ __ ___ _ __ | (___ | |_) || | > > > > | | | | '_ \ / _ \ '_ \ \___ \| _ < | | > > > > | |__| | |_) | __/ | | |____) | |_) || |_ > > > > \____/| .__/ \___|_| |_|_____/|___/_____| > > > > | | > > > > |_| > > > > > > > > init_coldboot: ipi init failed (error -1009) > > > > > > > > Just to note, because we use our own firmware that vendors in OpenSBI > > > > and compiles only a significantly cut down number of files from it, we > > > > do not use the fw_dynamic etc flow on our hardware. As a result, we have > > > > not tested v1.3, nor do we have any immediate plans to change our > > > > platform firmware to vendor v1.3 either. > > > > > > > > I unless there's something obvious to you, it sounds like I will need to > > > > go and bisect OpenSBI. That's a job for another day though, given the > > > > time. > > > > > > > > The real issue is some CPU/HART DT nodes marked as disabled in the > > DT passed to OpenSBI 1.3. > > > > This issue does not exist in any of the DTs generated by QEMU but some > > of the DTs in the kernel (such as microchip and SiFive board DTs) have > > the E-core disabled. > > > > I had discovered this issue in a totally different context after the OpenSBI 1.3 > > release happened. This issue is already fixed in the latest OpenSBI by the > > following commit c6a35733b74aeff612398f274ed19a74f81d1f37 ("lib: utils: > > Fix sbi_hartid_to_scratch() usage in ACLINT drivers"). > > Great, thanks Anup! I thought I had tested tip-of-tree too, but > obviously not. > > > I always assumed that Microchip hss.bin is the preferred BIOS for the > > QEMU microchip-icicle-kit machine but I guess that's not true. > > Unfortunately the HSS has not worked in QEMU for a long time, and while > I would love to fix it, but am pretty stretched for spare time to begin > with. > I usually just do direct kernel boots, which use the OpenSBI that comes > with QEMU, as I am sure you already know :) > > > At this point, you can either: > > 1) Use latest OpenSBI on QEMU microchip-icicle-kit machine I forgot to reply to this point, wondering what should be done with QEMU. Bumping to v1.3 in QEMU introduces a regression here, regardless of whether I can go and build a fixed version of OpenSBI. > > 2) Ensure CPU0 DT node is enabled in DT when booting on QEMU > > microchip-icicle-kit machine with OpenSBI 1.3 > > Will OpenSBI disable it? If not, I think option 2) needs to be remove > the DT node. I'll just use tip-of-tree myself & up to the Clearly didn't finish this comment. It was meant to say "up to the QEMU maintainers what they want to do on the QEMU side of things". Thanks, Conor. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: