From: Yong-Xuan Wang <yongxuan.wang@sifive.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 4/5] lib: sbi: Detect extensions from the ISA string in DT
Date: Tue, 24 Oct 2023 10:11:44 +0000 [thread overview]
Message-ID: <20231024101145.32000-5-yongxuan.wang@sifive.com> (raw)
In-Reply-To: <20231024101145.32000-1-yongxuan.wang@sifive.com>
Enable access to some extensions through menvcfg and show them in "Boot
HART ISA Extensions" if they are present in the device tree.
Signed-off-by: Yong-Xuan Wang <yongxuan.wang@sifive.com>
---
include/sbi/sbi_hart.h | 6 +++++
lib/sbi/sbi_hart.c | 51 +++++++++++++-----------------------------
2 files changed, 22 insertions(+), 35 deletions(-)
diff --git a/include/sbi/sbi_hart.h b/include/sbi/sbi_hart.h
index 33bf327..0424da8 100644
--- a/include/sbi/sbi_hart.h
+++ b/include/sbi/sbi_hart.h
@@ -42,6 +42,12 @@ enum sbi_hart_extensions {
SBI_HART_EXT_ZIHPM,
/** Hart has Smcntrpmf extension */
SBI_HART_EXT_SMCNTRPMF,
+ /** Hart has Zicboz extension */
+ SBI_HART_EXT_ZICBOZ,
+ /** Hart has Zicbom extension */
+ SBI_HART_EXT_ZICBOM,
+ /** Hart has Svpbmt extension */
+ SBI_HART_EXT_SVPBMT,
/** Maximum index of Hart extension */
SBI_HART_EXT_MAX,
diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
index add0155..4fb5153 100644
--- a/lib/sbi/sbi_hart.c
+++ b/lib/sbi/sbi_hart.c
@@ -112,46 +112,24 @@ static void mstatus_init(struct sbi_scratch *scratch)
menvcfg_val |= ((uint64_t)csr_read(CSR_MENVCFGH)) << 32;
#endif
- /*
- * Set menvcfg.CBZE == 1
- *
- * If Zicboz extension is not available then writes to
- * menvcfg.CBZE will be ignored because it is a WARL field.
- */
- menvcfg_val |= ENVCFG_CBZE;
+#define __set_menvcfg_ext(__ext, __bit) \
+ if (sbi_hart_has_extension(scratch, __ext)) { \
+ menvcfg_val |= __bit; \
+ }
/*
- * Set menvcfg.CBCFE == 1
- *
- * If Zicbom extension is not available then writes to
- * menvcfg.CBCFE will be ignored because it is a WARL field.
+ * Enable access to extensions if they are present in the
+ * hardware or in the device tree.
*/
- menvcfg_val |= ENVCFG_CBCFE;
- /*
- * Set menvcfg.CBIE == 3
- *
- * If Zicbom extension is not available then writes to
- * menvcfg.CBIE will be ignored because it is a WARL field.
- */
- menvcfg_val |= ENVCFG_CBIE_INV << ENVCFG_CBIE_SHIFT;
+ __set_menvcfg_ext(SBI_HART_EXT_ZICBOZ, ENVCFG_CBZE);
+ __set_menvcfg_ext(SBI_HART_EXT_ZICBOM, ENVCFG_CBCFE);
+ __set_menvcfg_ext(SBI_HART_EXT_ZICBOM,
+ ENVCFG_CBIE_INV << ENVCFG_CBIE_SHIFT);
+ __set_menvcfg_ext(SBI_HART_EXT_SVPBMT, ENVCFG_PBMTE);
+ __set_menvcfg_ext(SBI_HART_EXT_SSTC, ENVCFG_STCE);
- /*
- * Set menvcfg.PBMTE == 1 for RV64 or RV128
- *
- * If Svpbmt extension is not available then menvcfg.PBMTE
- * will be read-only zero.
- */
- menvcfg_val |= ENVCFG_PBMTE;
-
- /*
- * The spec doesn't explicitly describe the reset value of menvcfg.
- * Enable access to stimecmp if sstc extension is present in the
- * hardware.
- */
- if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SSTC)) {
- menvcfg_val |= ENVCFG_STCE;
- }
+#undef __set_menvcfg_ext
csr_write(CSR_MENVCFG, menvcfg_val);
#if __riscv_xlen == 32
@@ -666,6 +644,9 @@ const struct sbi_hart_ext_data sbi_hart_ext[] = {
__SBI_HART_EXT_DATA(zicntr, SBI_HART_EXT_ZICNTR),
__SBI_HART_EXT_DATA(zihpm, SBI_HART_EXT_ZIHPM),
__SBI_HART_EXT_DATA(smcntrpmf, SBI_HART_EXT_SMCNTRPMF),
+ __SBI_HART_EXT_DATA(zicboz, SBI_HART_EXT_ZICBOZ),
+ __SBI_HART_EXT_DATA(zicbom, SBI_HART_EXT_ZICBOM),
+ __SBI_HART_EXT_DATA(svpbmt, SBI_HART_EXT_SVPBMT),
};
/**
--
2.17.1
next prev parent reply other threads:[~2023-10-24 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 10:11 [PATCH v2 0/5] Add Svadu extension support Yong-Xuan Wang
2023-10-24 10:11 ` [PATCH v2 1/5] lib: sbi: Improve the code of privilege mode and extensions detection Yong-Xuan Wang
2023-10-24 10:11 ` [PATCH v2 2/5] lib: sbi: Refactor the code for enable extensions in menvfg CSR Yong-Xuan Wang
2023-10-24 10:11 ` [PATCH v2 3/5] lib: sbi: Using one array to define the name of extensions Yong-Xuan Wang
2023-10-24 10:11 ` Yong-Xuan Wang [this message]
2023-10-24 10:11 ` [PATCH v2 5/5] lib: sbi: Add support for Svadu extension Yong-Xuan Wang
2023-11-14 16:45 ` [PATCH v2 0/5] Add Svadu extension support Anup Patel
2023-11-24 4:55 ` Yong-Xuan Wang
2024-05-24 11:31 ` Alexandre Ghiti
2024-05-24 12:06 ` Conor Dooley
2024-05-24 12:47 ` Alexandre Ghiti
2024-05-24 13:11 ` Conor Dooley
2024-05-24 13:17 ` Conor Dooley
2024-05-24 16:05 ` Anup Patel
2024-05-24 19:38 ` Alexandre Ghiti
2024-05-27 12:22 ` Andrew Jones
2024-05-27 16:03 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024101145.32000-5-yongxuan.wang@sifive.com \
--to=yongxuan.wang@sifive.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox