From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2 08/17] lib: sbi: Add optional resume address to hart suspend
Date: Fri, 29 Nov 2024 21:20:43 +0530 [thread overview]
Message-ID: <20241129155052.2866712-9-apatel@ventanamicro.com> (raw)
In-Reply-To: <20241129155052.2866712-1-apatel@ventanamicro.com>
From: Subrahmanya Lingappa <slingappa@ventanamicro.com>
Add an optional resume address to the platform specific hart suspend call.
Signed-off-by: Subrahmanya Lingappa <slingappa@ventanamicro.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
include/sbi/sbi_hsm.h | 6 +++++-
lib/sbi/sbi_hsm.c | 6 +++---
platform/generic/allwinner/sun20i-d1.c | 2 +-
3 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/include/sbi/sbi_hsm.h b/include/sbi/sbi_hsm.h
index ae098f45..38f90516 100644
--- a/include/sbi/sbi_hsm.h
+++ b/include/sbi/sbi_hsm.h
@@ -40,8 +40,12 @@ struct sbi_hsm_device {
*
* For successful non-retentive suspend, the hart will resume from
* the warm boot entry point.
+ *
+ * NOTE: mmode_resume_addr(resume address) is optional hence it
+ * may or may not be honored by the platform. If its not honored
+ * then platform must ensure to resume from the warmboot address.
*/
- int (*hart_suspend)(u32 suspend_type);
+ int (*hart_suspend)(u32 suspend_type, ulong mmode_resume_addr);
/**
* Perform platform-specific actions to resume from a suspended state.
diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c
index a3d6947a..cf0eb84b 100644
--- a/lib/sbi/sbi_hsm.c
+++ b/lib/sbi/sbi_hsm.c
@@ -223,10 +223,10 @@ static int hsm_device_hart_stop(void)
return SBI_ENOTSUPP;
}
-static int hsm_device_hart_suspend(u32 suspend_type)
+static int hsm_device_hart_suspend(u32 suspend_type, ulong mmode_resume_addr)
{
if (hsm_dev && hsm_dev->hart_suspend)
- return hsm_dev->hart_suspend(suspend_type);
+ return hsm_dev->hart_suspend(suspend_type, mmode_resume_addr);
return SBI_ENOTSUPP;
}
@@ -532,7 +532,7 @@ int sbi_hsm_hart_suspend(struct sbi_scratch *scratch, u32 suspend_type,
__sbi_hsm_suspend_non_ret_save(scratch);
/* Try platform specific suspend */
- ret = hsm_device_hart_suspend(suspend_type);
+ ret = hsm_device_hart_suspend(suspend_type, scratch->warmboot_addr);
if (ret == SBI_ENOTSUPP) {
/* Try generic implementation of default suspend types */
if (suspend_type == SBI_HSM_SUSPEND_RET_DEFAULT ||
diff --git a/platform/generic/allwinner/sun20i-d1.c b/platform/generic/allwinner/sun20i-d1.c
index b65013c2..c31ebdb2 100644
--- a/platform/generic/allwinner/sun20i-d1.c
+++ b/platform/generic/allwinner/sun20i-d1.c
@@ -130,7 +130,7 @@ static void sun20i_d1_riscv_cfg_init(void)
writel_relaxed(entry >> 32, SUN20I_D1_RISCV_CFG_BASE + RESET_ENTRY_HI_REG);
}
-static int sun20i_d1_hart_suspend(u32 suspend_type)
+static int sun20i_d1_hart_suspend(u32 suspend_type, ulong mmode_resume_addr)
{
/* Use the generic code for retentive suspend. */
if (!(suspend_type & SBI_HSM_SUSP_NON_RET_BIT))
--
2.43.0
next prev parent reply other threads:[~2024-11-29 15:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 15:50 [PATCH v2 00/17] RPMI and SBI MPXY support for OpenSBI Anup Patel
2024-11-29 15:50 ` [PATCH v2 01/17] lib: Increase ROOT_REGION_MAX to accomodate more memregions Anup Patel
2024-11-29 15:50 ` [PATCH v2 02/17] lib: utils/mailbox: Add generic mailbox library Anup Patel
2024-11-29 15:50 ` [PATCH v2 03/17] lib: utils/mailbox: Add simple FDT based mailbox framework Anup Patel
2024-11-29 15:50 ` [PATCH v2 04/17] lib/utils: Add RPMI messaging protocol and shared memory transport support Anup Patel
2024-11-29 15:50 ` [PATCH v2 05/17] lib/utils: reset: Add RPMI System Reset driver Anup Patel
2024-11-29 15:50 ` [PATCH v2 06/17] lib: utils: Add simple FDT based system suspend driver framework Anup Patel
2024-11-29 15:50 ` [PATCH v2 07/17] lib: utils/suspend: Add RPMI system suspend driver Anup Patel
2024-11-29 15:50 ` Anup Patel [this message]
2024-11-29 15:50 ` [PATCH v2 09/17] lib: utils/fdt: Allow dynamic registration of FDT fixup callbacks Anup Patel
2024-11-29 15:50 ` [PATCH v2 10/17] lib: utils: Add simple FDT based HSM driver framework Anup Patel
2024-11-29 15:50 ` [PATCH v2 11/17] lib: utils/hsm: Add RPMI HSM driver Anup Patel
2024-11-29 15:50 ` [PATCH v2 12/17] lib: utils: Add simple FDT based CPPC driver framework Anup Patel
2024-11-29 15:50 ` [PATCH v2 13/17] lib: utils/cppc: Add RPMI CPPC driver Anup Patel
2024-11-29 15:50 ` [PATCH v2 14/17] lib: sbi: Add SBI Message Proxy (MPXY) framework Anup Patel
2024-11-29 15:50 ` [PATCH v2 15/17] lib: sbi: Implement SBI MPXY extension Anup Patel
2024-11-29 15:50 ` [PATCH v2 16/17] lib: utils: Add simple FDT based MPXY driver framework Anup Patel
2024-11-29 15:50 ` [PATCH v2 17/17] lib: utils/mpxy: Add RPMI client driver for MPXY Anup Patel
2024-12-06 3:55 ` [PATCH v2 00/17] RPMI and SBI MPXY support for OpenSBI Anup Patel
2024-12-06 5:08 ` Samuel Holland
2024-12-06 11:32 ` Anup Patel
2024-12-15 21:49 ` Samuel Holland
2024-12-16 8:57 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129155052.2866712-9-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox