OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Anup Patel <apatel@ventanamicro.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 06/12] lib: utils: Drop notifications from MPXY RPMI mailbox client
Date: Thu, 16 Jan 2025 21:26:45 +0530	[thread overview]
Message-ID: <20250116155651.103782-7-apatel@ventanamicro.com> (raw)
In-Reply-To: <20250116155651.103782-1-apatel@ventanamicro.com>

Currently, the common MPXY RPMI mailbox client does not support
notifications so no need for dummy notifications support.

Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
 include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h |  1 -
 lib/utils/mpxy/fdt_mpxy_rpmi_clock.c        |  1 -
 lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c         | 10 ----------
 3 files changed, 12 deletions(-)

diff --git a/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h b/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h
index 08b32a0a..53a8d8bd 100644
--- a/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h
+++ b/include/sbi_utils/mpxy/fdt_mpxy_rpmi_mbox.h
@@ -77,7 +77,6 @@ struct mpxy_rpmi_service_group_ops {
 struct mpxy_rpmi_mbox_data {
 	u32 servicegrp_id;
 	u32 num_services;
-	u32 notifications_support;
 	struct mpxy_rpmi_service_data *service_data;
 	struct mpxy_rpmi_service_group_ops *group_ops;
 };
diff --git a/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c b/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c
index 3d275cd8..125539ac 100644
--- a/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c
+++ b/lib/utils/mpxy/fdt_mpxy_rpmi_clock.c
@@ -75,7 +75,6 @@ static struct mpxy_rpmi_service_data clock_services[] = {
 static struct mpxy_rpmi_mbox_data clock_data = {
 	.servicegrp_id = RPMI_SRVGRP_CLOCK,
 	.num_services = RPMI_CLOCK_SRV_MAX_COUNT,
-	.notifications_support = 1,
 	.service_data = clock_services,
 	.group_ops = &clock_ops,
 };
diff --git a/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c b/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c
index 8d892cef..26b9e6a6 100644
--- a/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c
+++ b/lib/utils/mpxy/fdt_mpxy_rpmi_mbox.c
@@ -213,13 +213,6 @@ static int mpxy_mbox_send_message_withoutresp(struct sbi_mpxy_channel *channel,
 				 NULL, 0, NULL);
 }
 
-static int mpxy_mbox_get_notifications(struct sbi_mpxy_channel *channel,
-				       void *eventsbuf, u32 bufsize,
-				       unsigned long *events_len)
-{
-	return SBI_ENOTSUPP;
-}
-
 int mpxy_rpmi_mbox_init(const void *fdt, int nodeoff, const struct fdt_match *match)
 {
 	int rc, len;
@@ -277,9 +270,6 @@ int mpxy_rpmi_mbox_init(const void *fdt, int nodeoff, const struct fdt_match *ma
 					mpxy_mbox_send_message_withresp;
 	rmb->channel.send_message_without_response =
 					mpxy_mbox_send_message_withoutresp;
-	/* Callback to get RPMI notifications */
-	rmb->channel.get_notification_events = mpxy_mbox_get_notifications;
-
 	/* No callback to switch events state data */
 	rmb->channel.switch_eventsstate = NULL;
 
-- 
2.43.0



  parent reply	other threads:[~2025-01-16 15:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-16 15:56 [PATCH 00/12] More RPMI and MPXY updates Anup Patel
2025-01-16 15:56 ` [PATCH 01/12] lib: utils: Split the FDT MPXY RPMI mailbox client into two parts Anup Patel
2025-01-19 22:52   ` Samuel Holland
2025-01-20  4:49     ` Anup Patel
2025-01-16 15:56 ` [PATCH 02/12] lib: utils: Constantify mpxy_rpmi_mbox_data in mpxy_rpmi_mbox Anup Patel
2025-01-19 22:54   ` Samuel Holland
2025-01-20  5:12     ` Anup Patel
2025-01-16 15:56 ` [PATCH 03/12] lib: utils: Introduce optional MPXY RPMI service group operations Anup Patel
2025-01-19 22:58   ` Samuel Holland
2025-01-20  8:05     ` Anup Patel
2025-01-16 15:56 ` [PATCH 04/12] lib: sbi: Fix capability bit assignment in MPXY framework Anup Patel
2025-01-19 23:00   ` Samuel Holland
2025-01-16 15:56 ` [PATCH 05/12] lib: sbi: Improve local variable declarations " Anup Patel
2025-01-19 23:02   ` Samuel Holland
2025-01-16 15:56 ` Anup Patel [this message]
2025-01-19 23:02   ` [PATCH 06/12] lib: utils: Drop notifications from MPXY RPMI mailbox client Samuel Holland
2025-01-16 15:56 ` [PATCH 07/12] lib: utils: Improve variable declarations in " Anup Patel
2025-01-19 23:05   ` Samuel Holland
2025-01-20  8:37     ` Anup Patel
2025-01-16 15:56 ` [PATCH 08/12] include: sbi_utils: Include mailbox.h in rpmi_mailbox.h header Anup Patel
2025-01-19 23:05   ` Samuel Holland
2025-01-16 15:56 ` [PATCH 09/12] lib: utils: Implement get_attribute() for the RPMI shared memory mailbox Anup Patel
2025-01-16 15:56 ` [PATCH 10/12] lib: utils: Populate MPXY channel attributes from RPMI channel attributes Anup Patel
2025-01-16 15:56 ` [PATCH 11/12] include: sbi_utils: Update RPMI service group IDs and BASE service group Anup Patel
2025-01-19 23:07   ` Samuel Holland
2025-01-16 15:56 ` [PATCH 12/12] lib: utils: Add MPXY RPMI mailbox driver for System MSI " Anup Patel
2025-01-19 23:11   ` Samuel Holland
2025-01-20  9:16     ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250116155651.103782-7-apatel@ventanamicro.com \
    --to=apatel@ventanamicro.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox