From: Anup Patel <apatel@ventanamicro.com>
To: Atish Patra <atishp@rivosinc.com>
Cc: Andrew Jones <ajones@ventanamicro.com>,
Anup Patel <anup@brainfault.org>,
Raj Vishwanathan <Raj.Vishwanathan@gmail.com>,
opensbi@lists.infradead.org, Anup Patel <apatel@ventanamicro.com>,
Maria Mbaye <MameMaria.Mbaye@microchip.com>
Subject: [PATCH] lib: utils: Fix fdt_parse_aclint_node() for non-contiguous hartid
Date: Fri, 6 Jun 2025 11:28:10 +0530 [thread overview]
Message-ID: <20250606055810.237441-1-apatel@ventanamicro.com> (raw)
Currently, the fdt_parse_aclint_node() does not handle non-contiguous
hartid correctly and returns incorrect first_hartid and hart_count.
This is because the for-loop in fdt_parse_aclint_node() skips a hartid
for which hartindex is not available (aka corresponding CPU DT node
is disabled).
For example, on a platform with 4 HARTs (hartid 0, 1, 2, and 3) where
CPU DT nodes with hartid 0 and 2 are disabled, the fdt_parse_aclint_node()
returns first_hartid = 1 and hart_count = 3 which is incorrect.
To address the above issue, drop the sbi_hartid_to_hartindex() check
from the for-loop of fdt_parse_aclint_node().
Fixes: 5e90e54a1a53 ("lib: utils:Check that hartid is valid")
Reported-by: Maria Mbaye <MameMaria.Mbaye@microchip.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
---
lib/utils/fdt/fdt_helper.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/utils/fdt/fdt_helper.c b/lib/utils/fdt/fdt_helper.c
index b2d91fdf..4c0e8221 100644
--- a/lib/utils/fdt/fdt_helper.c
+++ b/lib/utils/fdt/fdt_helper.c
@@ -1013,9 +1013,6 @@ int fdt_parse_aclint_node(const void *fdt, int nodeoffset,
if (rc)
continue;
- if (SBI_HARTMASK_MAX_BITS <= sbi_hartid_to_hartindex(hartid))
- continue;
-
if (match_hwirq == hwirq) {
if (hartid < first_hartid)
first_hartid = hartid;
--
2.43.0
--
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi
next reply other threads:[~2025-06-06 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 5:58 Anup Patel [this message]
2025-06-16 4:18 ` [PATCH] lib: utils: Fix fdt_parse_aclint_node() for non-contiguous hartid Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250606055810.237441-1-apatel@ventanamicro.com \
--to=apatel@ventanamicro.com \
--cc=MameMaria.Mbaye@microchip.com \
--cc=Raj.Vishwanathan@gmail.com \
--cc=ajones@ventanamicro.com \
--cc=anup@brainfault.org \
--cc=atishp@rivosinc.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox