From: Jessica Clarke <jrtc27@jrtc27.com>
To: opensbi@lists.infradead.org
Cc: Jessica Clarke <jrtc27@jrtc27.com>
Subject: [PATCH] firmware: Rename __rel_dyn_start/end to __rela_dyn_start/end
Date: Thu, 10 Jul 2025 01:29:35 +0100 [thread overview]
Message-ID: <20250710002937.44307-1-jrtc27@jrtc27.com> (raw)
We are using and expecting the RELA format, not the REL format, and this
is the conventional linker-generated name for the start/end symbols, so
use it rather than confusing things by making it look like we're
accessing .rel.dyn, which would be in the REL format with no explicit
addend.
Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
---
firmware/fw_base.S | 4 ++--
firmware/fw_base.ldS | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/firmware/fw_base.S b/firmware/fw_base.S
index aa8e264..b675c9e 100644
--- a/firmware/fw_base.S
+++ b/firmware/fw_base.S
@@ -76,8 +76,8 @@ _sc_fail:
li t0, FW_TEXT_START /* link start */
lla t1, _fw_start /* load start */
sub t2, t1, t0 /* load offset */
- lla t0, __rel_dyn_start
- lla t1, __rel_dyn_end
+ lla t0, __rela_dyn_start
+ lla t1, __rela_dyn_end
beq t0, t1, _relocate_done
2:
REG_L t5, __SIZEOF_LONG__(t0) /* t5 <-- relocation info:type */
diff --git a/firmware/fw_base.ldS b/firmware/fw_base.ldS
index a33746a..12c7a84 100644
--- a/firmware/fw_base.ldS
+++ b/firmware/fw_base.ldS
@@ -47,9 +47,9 @@
. = ALIGN(0x1000); /* Ensure next section is page aligned */
.rela.dyn : {
- PROVIDE(__rel_dyn_start = .);
+ PROVIDE(__rela_dyn_start = .);
*(.rela*)
- PROVIDE(__rel_dyn_end = .);
+ PROVIDE(__rela_dyn_end = .);
}
PROVIDE(_rodata_end = .);
--
2.34.1
--
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi
next reply other threads:[~2025-07-10 1:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 0:29 Jessica Clarke [this message]
2025-07-18 8:01 ` [PATCH] firmware: Rename __rel_dyn_start/end to __rela_dyn_start/end Samuel Holland
2025-07-21 11:13 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710002937.44307-1-jrtc27@jrtc27.com \
--to=jrtc27@jrtc27.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox