public inbox for opensbi@lists.infradead.org
 help / color / mirror / Atom feed
From: Jesse Taube <jesse@rivosinc.com>
To: opensbi@lists.infradead.org
Cc: Himanshu Chauhan <hchauhan@ventanamicro.com>,
	Anup Patel <anup@brainfault.org>,
	Charlie Jenkins <charlie@rivosinc.com>,
	Jesse Taube <jesse@rivosinc.com>
Subject: [PATCH] Clarify sbi_debug_read_triggers return values
Date: Tue, 29 Jul 2025 10:36:01 -0700	[thread overview]
Message-ID: <20250729173601.2098669-1-jesse@rivosinc.com> (raw)

Clarify that `sbi_debug_read_triggers` must read the configuration
from CSRs.

Closes: #213
Signed-off-by: Jesse Taube <jesse@rivosinc.com>
---
 src/ext-debug-triggers.adoc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/ext-debug-triggers.adoc b/src/ext-debug-triggers.adoc
index 2a5bcf9..3fd9093 100644
--- a/src/ext-debug-triggers.adoc
+++ b/src/ext-debug-triggers.adoc
@@ -133,8 +133,9 @@ struct sbiret sbi_debug_read_triggers(unsigned long trig_idx_base,
                                       unsigned long trig_count)
 ----
 
-Read the debug trigger state and configuration into shared memory for a range of debug
-triggers specified by the `trig_idx_base` and `trig_count` parameters on the calling hart.
+Read the saved debug trigger software state and read the current configuration
+from their respective CSRs into shared memory for a range of debug triggers
+specified by the `trig_idx_base` and `trig_count` parameters on the calling hart.
 
 For each debug trigger with index `trig_idx_base + i` where `-1 < i < trig_count`, the
 debug trigger state and configuration consisting of four XLEN-bit words are written in
-- 
2.43.0


-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

                 reply	other threads:[~2025-07-29 17:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250729173601.2098669-1-jesse@rivosinc.com \
    --to=jesse@rivosinc.com \
    --cc=anup@brainfault.org \
    --cc=charlie@rivosinc.com \
    --cc=hchauhan@ventanamicro.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox