From: Yu-Chien Peter Lin <peter.lin@sifive.com>
To: opensbi@lists.infradead.org
Cc: zong.li@sifive.com, greentime.hu@sifive.com, wxjstz@126.com,
alvinga@andestech.com, anup@brainfault.org,
Yu-Chien Peter Lin <peter.lin@sifive.com>
Subject: [PATCH v2 8/8] lib: sbi_domain_context: preserve firmware PMP entries during domain context switch
Date: Wed, 8 Oct 2025 16:44:44 +0800 [thread overview]
Message-ID: <20251008084444.3525615-9-peter.lin@sifive.com> (raw)
In-Reply-To: <20251008084444.3525615-1-peter.lin@sifive.com>
When SmePMP is enabled, clearing firmware PMP entries during a domain
context switch can temporarily revoke access to OpenSBI’s own code and
data, leading to faults.
Keep firmware PMP entries enabled across switches so firmware regions
remain accessible and executable.
Signed-off-by: Yu-Chien Peter Lin <peter.lin@sifive.com>
---
lib/sbi/sbi_domain_context.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/sbi/sbi_domain_context.c b/lib/sbi/sbi_domain_context.c
index fb04d81d..51534de1 100644
--- a/lib/sbi/sbi_domain_context.c
+++ b/lib/sbi/sbi_domain_context.c
@@ -116,6 +116,10 @@ static void switch_to_next_domain_context(struct hart_context *ctx,
/* Reconfigure PMP settings for the new domain */
for (int i = 0; i < pmp_count; i++) {
+ /* Don't revoke firmware access permissions */
+ if (sbi_hart_smepmp_is_fw_region(i))
+ continue;
+
sbi_platform_pmp_disable(sbi_platform_thishart_ptr(), i);
pmp_disable(i);
}
--
2.48.0
--
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi
next prev parent reply other threads:[~2025-10-08 8:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 8:44 [PATCH v2 0/8] SmePMP bugfixes and improvement Yu-Chien Peter Lin
2025-10-08 8:44 ` [PATCH v2 1/8] lib: sbi_hart: move sbi_hart_get_smepmp_flags() to sbi_domain Yu-Chien Peter Lin
2025-11-02 10:27 ` Anup Patel
2025-10-08 8:44 ` [PATCH v2 2/8] lib: sbi_domain: allow specifying inaccessible region Yu-Chien Peter Lin
2025-11-02 10:32 ` Anup Patel
2025-10-08 8:44 ` [PATCH v2 3/8] lib: sbi_domain: print unsupported SmePMP permissions Yu-Chien Peter Lin
2025-11-02 10:40 ` Anup Patel
2025-10-08 8:44 ` [PATCH v2 4/8] lib: sbi_hart: return error when insufficient PMP entries available Yu-Chien Peter Lin
2025-11-02 10:55 ` Anup Patel
2025-10-08 8:44 ` [PATCH v2 5/8] lib: sbi_domain: add SBI_DOMAIN_MEMREGION_FW memregion flag Yu-Chien Peter Lin
2025-11-02 10:55 ` Anup Patel
2025-10-08 8:44 ` [PATCH v2 6/8] lib: sbi_domain: ensure consistent firmware PMP entries Yu-Chien Peter Lin
2025-11-02 11:04 ` Anup Patel
2025-10-08 8:44 ` [PATCH v2 7/8] lib: sbi: sbi_hart: track firmware PMP entries when configuring SmePMP Yu-Chien Peter Lin
2025-11-02 11:28 ` Anup Patel
2025-10-08 8:44 ` Yu-Chien Peter Lin [this message]
2025-11-02 11:41 ` [PATCH v2 8/8] lib: sbi_domain_context: preserve firmware PMP entries during domain context switch Anup Patel
2025-11-02 12:29 ` [PATCH v2 0/8] SmePMP bugfixes and improvement Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008084444.3525615-9-peter.lin@sifive.com \
--to=peter.lin@sifive.com \
--cc=alvinga@andestech.com \
--cc=anup@brainfault.org \
--cc=greentime.hu@sifive.com \
--cc=opensbi@lists.infradead.org \
--cc=wxjstz@126.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox