OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Pei <cp0613@linux.alibaba.com>
To: opensbi@lists.infradead.org
Cc: anup@brainfault.org, atishp@rivosinc.com, wxjstz@126.com,
	guoren@kernel.org
Subject: Re: [PATCH] lib/utils/fdt: Reserve enough FDT space for fdt_cpu_fixup
Date: Tue,  7 Jul 2026 21:01:35 +0800	[thread overview]
Message-ID: <20260707130135.35276-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <20260612075502.76324-1-cp0613@linux.alibaba.com>

Hello everyone,

Friendly ping on this patch. Is there any comment on this fix? Thanks.

To summarize, this patch fixes a real issue where fdt_cpu_fixup()
reserves only a hardcoded +32 bytes when disabling HART DT nodes and
appending the "zicntr" isa-extension. On systems with many disabled
HARTs, fdt_setprop_string() silently returns -FDT_ERR_NOSPACE after
roughly 8 HARTs, leaving the remaining CPU nodes unexpectedly enabled
in the DTB passed to the OS.

The fix replaces the hardcoded reservation with a dynamic calculation
based on SBI_HARTMASK_MAX_BITS and removes the now-redundant per-HART
fdt_open_into() call in the zicntr loop.

Thanks,
Pei

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

      parent reply	other threads:[~2026-07-07 13:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12  7:55 [PATCH] lib/utils/fdt: Reserve enough FDT space for fdt_cpu_fixup Chen Pei
2026-07-07 12:58 ` Chen Pei
2026-07-07 13:01 ` Chen Pei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707130135.35276-1-cp0613@linux.alibaba.com \
    --to=cp0613@linux.alibaba.com \
    --cc=anup@brainfault.org \
    --cc=atishp@rivosinc.com \
    --cc=guoren@kernel.org \
    --cc=opensbi@lists.infradead.org \
    --cc=wxjstz@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox