OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Pei <cp0613@linux.alibaba.com>
To: opensbi@lists.infradead.org
Cc: Anup Patel <anup@brainfault.org>,
	Andrew Jones <andrew.jones@oss.qualcomm.com>,
	Guo Ren <guoren@kernel.org>
Subject: Re: [PATCH] lib: sbi_ipi: Validate hartids against domain, not HSM state
Date: Tue,  7 Jul 2026 21:09:32 +0800	[thread overview]
Message-ID: <20260707130938.40197-1-cp0613@linux.alibaba.com> (raw)
In-Reply-To: <20260612115208.118132-1-cp0613@linux.alibaba.com>

Hello everyone,

Friendly ping on this patch. Is there any comment on this fix? Thanks.

To summarize, commit 37eaca4ab33d ("lib: sbi_ipi: Return error for
invalid hartids") added a weight check against the HSM-interruptible
mask. This causes sbi_ipi_send_many() to return SBI_EINVAL when the
kernel sends a remote fence whose hmask includes a hart that was
stopped by CPU hotplug, because STOPPED harts are excluded from the
HSM-interruptible mask:

  __sbi_rfence_v02_call: hbase = [0] hmask = [0x3] failed (error [-22])

This patch changes the validation to use the domain's assigned hartmask
instead, which still rejects truly invalid or cross-domain hartids
while allowing HSM-STOPPED harts to be silently skipped.

Thanks,
Pei

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

      reply	other threads:[~2026-07-07 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-12 11:52 [PATCH] lib: sbi_ipi: Validate hartids against domain, not HSM state Chen Pei
2026-07-07 13:09 ` Chen Pei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707130938.40197-1-cp0613@linux.alibaba.com \
    --to=cp0613@linux.alibaba.com \
    --cc=andrew.jones@oss.qualcomm.com \
    --cc=anup@brainfault.org \
    --cc=guoren@kernel.org \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox