OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yu-Chien Peter Lin <peter.lin@sifive.com>
To: opensbi@lists.infradead.org, anup@brainfault.org,
	pawandeep.oza@oss.qualcomm.com, rkrcmar@qti.qualcomm.com
Cc: raymond.mao@riscstar.com, robin.randhawa@sifive.com,
	samuel.holland@sifive.com, zong.li@sifive.com,
	greentime.hu@sifive.com,
	Yu-Chien Peter Lin <peter.lin@sifive.com>
Subject: [PATCH v5 4/9] lib: sbi_hart: lock mwid CSR for RoT immutability
Date: Tue, 10 Nov 2026 17:50:24 +0800	[thread overview]
Message-ID: <20261110095029.117504-5-peter.lin@sifive.com> (raw)
In-Reply-To: <20261110095029.117504-1-peter.lin@sifive.com>

Lock the M-mode World ID (mwid) CSR during hart re-initialization
to enforce immutability of the WID established by the root-of-trust.

OpenSBI does not assign the WID value itself; it only sets MWID_LOCK
to freeze the value established by prior RoT stage. The MWID_LOCK bit
at XLEN-1 is sticky and makes the CSR read-only until reset, enforcing
a temporal security boundary per the RISC-V Worlds specification.

Signed-off-by: Yu-Chien Peter Lin <peter.lin@sifive.com>
---
Changes v4->v5:
- Move the MWID lock out of sbi_hart_reinit() into smwid_hart_init()
- Drop RB-tags from Oza and Anup
---
 lib/sbi/sbi_hart.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c
index d86abf07..a721bef4 100644
--- a/lib/sbi/sbi_hart.c
+++ b/lib/sbi/sbi_hart.c
@@ -469,6 +469,16 @@ static int hart_mhpm_get_allowed_bits(void)
 	return num_bits;
 }
 
+static void smwid_hart_init(struct sbi_scratch *scratch)
+{
+	/*
+	 * Assume MWID is restored by root-of-trust M-mode in previous
+	 * stage. Lock mwid so RoT-defined WID remains immutable.
+	 */
+	if (sbi_hart_has_extension(scratch, SBI_HART_EXT_SMWID))
+		csr_set(CSR_MWID, MWID_LOCK);
+}
+
 static int smrnmi_hart_init(struct sbi_scratch *scratch)
 {
 	const struct sbi_platform *plat;
@@ -721,6 +731,8 @@ int sbi_hart_reinit(struct sbi_scratch *scratch)
 {
 	int rc;
 
+	smwid_hart_init(scratch);
+
 	rc = smrnmi_hart_init(scratch);
 	if (rc)
 		return rc;
-- 
2.43.7


-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

  parent reply	other threads:[~2026-11-10  9:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10  9:50 [PATCH v5 0/9] Add RISC-V Worlds ISA support to OpenSBI Yu-Chien Peter Lin
2026-11-10  9:50 ` [PATCH v5 1/9] lib: sbi_hart: add RISC-V Worlds ISA extensions Yu-Chien Peter Lin
2026-11-10 18:48   ` Pawandeep Oza
2026-11-10  9:50 ` [PATCH v5 2/9] lib: utils: fdt_helper: parse RISC-V Worlds per-hart WID properties Yu-Chien Peter Lin
2026-11-10 18:48   ` Pawandeep Oza
2026-11-10  9:50 ` [PATCH v5 3/9] lib: fdt_domain: parse domain " Yu-Chien Peter Lin
2026-11-10 18:48   ` Pawandeep Oza
2026-11-16 13:14   ` Anup Patel
2026-11-10  9:50 ` Yu-Chien Peter Lin [this message]
2026-11-10 18:49   ` [PATCH v5 4/9] lib: sbi_hart: lock mwid CSR for RoT immutability Pawandeep Oza
2026-11-16 13:19   ` Anup Patel
2026-11-18  2:00     ` Yu-Chien Peter Lin
2026-11-18  4:55       ` Yu-Chien Peter Lin
2026-11-10  9:50 ` [PATCH v5 5/9] lib: sbi_domain_context: propagate error from sbi_hart_protection_reconfigure Yu-Chien Peter Lin
2026-11-10  9:50 ` [PATCH v5 6/9] lib: sbi_hart_worlds: Implement WID hart protection backend Yu-Chien Peter Lin
2026-11-10 18:49   ` Pawandeep Oza
2026-11-16 13:21   ` Anup Patel
2026-11-10  9:50 ` [PATCH v5 7/9] include: sbi_types: add PRIx64 format macro Yu-Chien Peter Lin
2026-11-10 18:49   ` Pawandeep Oza
2026-11-10  9:50 ` [PATCH v5 8/9] lib: sbi: display World ID configuration at boot Yu-Chien Peter Lin
2026-11-10  9:50 ` [PATCH v5 9/9] docs: document WID DT properties Yu-Chien Peter Lin
2026-11-10 18:50   ` Pawandeep Oza
2026-11-16 13:32   ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110095029.117504-5-peter.lin@sifive.com \
    --to=peter.lin@sifive.com \
    --cc=anup@brainfault.org \
    --cc=greentime.hu@sifive.com \
    --cc=opensbi@lists.infradead.org \
    --cc=pawandeep.oza@oss.qualcomm.com \
    --cc=raymond.mao@riscstar.com \
    --cc=rkrcmar@qti.qualcomm.com \
    --cc=robin.randhawa@sifive.com \
    --cc=samuel.holland@sifive.com \
    --cc=zong.li@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox