From: Atish Patra <atish.patra@linux.dev>
To: thecharlesjenkins@gmail.com, opensbi@lists.infradead.org
Subject: Re: [PATCH] lib: sbi_pmu: Track SBI_PMU_FW_PLATFORM started counter
Date: Mon, 2 Feb 2026 11:28:08 -0800 [thread overview]
Message-ID: <2eed3524-7faa-4311-9f2c-8d790f792f6e@linux.dev> (raw)
In-Reply-To: <20260127-pmu_platform_stop-v1-1-b07d1abd1ef2@gmail.com>
On 1/27/26 3:58 PM, Charlie Jenkins via B4 Relay wrote:
> From: Charlie Jenkins <thecharlesjenkins@gmail.com>
>
> When a SBI_PMU_FW_PLATFORM starts, add the counter to the counter array
> instead of returning early. This will cause fw_counter_stop() to be
> called when a SBI_PMU_FW_PLATFORM counter should be stopped.
>
> Signed-off-by: Charlie Jenkins <thecharlesjenkins@gmail.com>
> ---
> lib/sbi/sbi_pmu.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/lib/sbi/sbi_pmu.c b/lib/sbi/sbi_pmu.c
> index e084005d..3c61079b 100644
> --- a/lib/sbi/sbi_pmu.c
> +++ b/lib/sbi/sbi_pmu.c
> @@ -448,6 +448,8 @@ static int pmu_ctr_start_fw(struct sbi_pmu_hart_state *phs,
> uint64_t event_data, uint64_t ival,
> bool ival_update)
> {
> + int rc = 0;
> +
> if ((event_code >= SBI_PMU_FW_MAX &&
> event_code <= SBI_PMU_FW_RESERVED_MAX) ||
> event_code > SBI_PMU_FW_PLATFORM)
> @@ -468,9 +470,9 @@ static int pmu_ctr_start_fw(struct sbi_pmu_hart_state *phs,
> cidx - num_hw_ctrs,
> ival);
>
> - return pmu_dev->fw_counter_start(phs->hartid,
> - cidx - num_hw_ctrs,
> - event_data);
> + rc = pmu_dev->fw_counter_start(phs->hartid,
> + cidx - num_hw_ctrs,
> + event_data);
> } else {
> if (ival_update)
> phs->fw_counters_data[cidx - num_hw_ctrs] = ival;
> @@ -478,7 +480,7 @@ static int pmu_ctr_start_fw(struct sbi_pmu_hart_state *phs,
>
> phs->fw_counters_started |= BIT(cidx - num_hw_ctrs);
>
> - return 0;
> + return rc;
> }
>
> static void pmu_update_inhibit_flags(unsigned long flags, uint64_t *mhpmevent_val)
>
Reviewed-by: Atish Patra <atishp@meta.com>
> ---
> base-commit: 74434f255873d74e56cc50aa762d1caf24c099f8
> change-id: 20260127-pmu_platform_stop-febef65abf54
>
> - Charlie
>
>
>
--
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi
next prev parent reply other threads:[~2026-02-02 19:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 23:58 [PATCH] lib: sbi_pmu: Track SBI_PMU_FW_PLATFORM started counter Charlie Jenkins via B4 Relay
2026-02-02 19:28 ` Atish Patra [this message]
2026-02-23 4:59 ` Anup Patel
2026-02-26 0:35 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eed3524-7faa-4311-9f2c-8d790f792f6e@linux.dev \
--to=atish.patra@linux.dev \
--cc=opensbi@lists.infradead.org \
--cc=thecharlesjenkins@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox