From mboxrd@z Thu Jan  1 00:00:00 1970
From: Xiang W <wxjstz@126.com>
Date: Sun, 11 Apr 2021 18:07:48 +0800
Subject: [PATCH 7/7] lib: sbi: Make sbi_domain_memregion_initfw() a
 local function
In-Reply-To: <20210410071808.759856-8-anup.patel@wdc.com>
References: <20210410071808.759856-1-anup.patel@wdc.com>
 <20210410071808.759856-8-anup.patel@wdc.com>
Message-ID: <608cf300bfbe938d12fd85598e4f0b65d939f434.camel@126.com>
List-Id: <opensbi.lists.infradead.org>
To: opensbi@lists.infradead.org
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

? 2021-04-10?? 12:48 +0530?Anup Patel???
> The sbi_domain_memregion_initfw() is no longer used outside
> sbi_domain.c so let's make it a local function.
> 
> Signed-off-by: Anup Patel <anup.patel@wdc.com>
looks good to me.

Reviewed-by: Xiang W <wxjstz@126.com>

Regards,
Xiang W
> ---
>  include/sbi/sbi_domain.h | 3 ---
>  lib/sbi/sbi_domain.c     | 4 ++--
>  2 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/include/sbi/sbi_domain.h b/include/sbi/sbi_domain.h
> index ef53ca5..3de5e46 100644
> --- a/include/sbi/sbi_domain.h
> +++ b/include/sbi/sbi_domain.h
> @@ -127,9 +127,6 @@ bool sbi_domain_is_assigned_hart(const struct
> sbi_domain *dom, u32 hartid);
>  ulong sbi_domain_get_assigned_hartmask(const struct sbi_domain *dom,
>  				       ulong hbase);
>  
> -/** Initialize a domain memory region as firmware region */
> -void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg);
> -
>  /**
>   * Initialize a domain memory region based on it's physical
>   * address and size.
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 5e3a30d..069e2a7 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -64,7 +64,7 @@ ulong sbi_domain_get_assigned_hartmask(const struct
> sbi_domain *dom,
>  	return ret;
>  }
>  
> -void sbi_domain_memregion_initfw(struct sbi_domain_memregion *reg)
> +static void domain_memregion_initfw(struct sbi_domain_memregion
> *reg)
>  {
>  	if (!reg)
>  		return;
> @@ -577,7 +577,7 @@ int sbi_domain_init(struct sbi_scratch *scratch,
> u32 cold_hartid)
>  	/* Root domain firmware memory region */
>  	sbi_domain_memregion_init(scratch->fw_start, scratch->fw_size,
> 0,
>  				  &root_fw_region);
> -	sbi_domain_memregion_initfw(&root_memregs[root_memregs_count++]
> );
> +	domain_memregion_initfw(&root_memregs[root_memregs_count++]);
>  
>  	/* Root domain allow everything memory region */
>  	sbi_domain_memregion_init(0, ~0UL,
> -- 
> 2.25.1
> 
>