From: Andreas Schwab <schwab@linux-m68k.org>
To: opensbi@lists.infradead.org
Subject: [PATCH v2] Makefile: Pass relative paths to the compiler.
Date: Mon, 29 Nov 2021 11:35:00 +0100 [thread overview]
Message-ID: <87a6hnp7vv.fsf@igel.home> (raw)
In-Reply-To: <20211129015502.4767-1-vagrant@reproducible-builds.org> (Vagrant Cascadian's message of "Sun, 28 Nov 2021 17:55:03 -0800")
On Nov 28 2021, Vagrant Cascadian wrote:
> diff --git a/Makefile b/Makefile
> index 8623c1c..d017534 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -361,7 +361,7 @@ compile_cc_dep = $(CMD_PREFIX)mkdir -p `dirname $(1)`; \
> -MM $(2) >> $(1) || rm -f $(1)
> compile_cc = $(CMD_PREFIX)mkdir -p `dirname $(1)`; \
> echo " CC $(subst $(build_dir)/,,$(1))"; \
> - $(CC) $(CFLAGS) $(call dynamic_flags,$(1),$(2)) -c $(2) -o $(1)
> + $(CC) $(CFLAGS) $(call dynamic_flags,$(1),$(2)) -c $(subst $(src_dir)/,,$(2)) -o $(1)
How about making src_dir empty throughout? This now depends on
$(src_dir) being identical to ".", so making that explicit would be
better.
Andreas.
--
Andreas Schwab, schwab at linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
next prev parent reply other threads:[~2021-11-29 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 1:55 [PATCH v2] Makefile: Pass relative paths to the compiler Vagrant Cascadian
2021-11-29 3:05 ` Dong Du
2021-11-29 3:58 ` Xiang W
2021-11-29 10:35 ` Andreas Schwab [this message]
2021-11-29 18:13 ` Vagrant Cascadian
2021-12-02 3:46 ` Anup Patel
2021-12-03 20:43 ` Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6hnp7vv.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox