Re: [PATCH v5 1/6] lib: sbi: select expected trap handler per hart

From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: "Anup Patel" <anup@brainfault.org>, <opensbi@lists.infradead.org>
Cc: "Xianbin Zhu" <xianbin.zhu@linux.spacemit.com>,
	"Bo Gan" <ganboing@gmail.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>,
	"Kevin Zhang" <zhangmeng.kevin@linux.spacemit.com>,
	"Troy Mitchell" <troy.mitchell@linux.spacemit.com>,
	"Alvin Chang" <alvinga@andestech.com>,
	"E Shattow" <e@freeshell.de>
Subject: Re: [PATCH v5 1/6] lib: sbi: select expected trap handler per hart
Date: Fri, 23 Oct 2026 14:14:02 +0800	[thread overview]
Message-ID: <DMBZW0LZ8UPA.281J6KS3ZCIOM@linux.spacemit.com> (raw)
In-Reply-To: <CAAhSdy1fLZ1W+d05v_CXRwRq7Uz__UL5CaHfgpRQ1xHsxBm6Eg@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 918 bytes --]

Hi Anup,

On Fri, Oct 23, 2026 at 09:38:29AM +0530, Anup Patel wrote:
> > diff --git a/include/sbi/sbi_scratch.h b/include/sbi/sbi_scratch.h
> > index 06097c8a..20e7dcd0 100644
> > --- a/include/sbi/sbi_scratch.h
> > +++ b/include/sbi/sbi_scratch.h
> > [...]
> > @@ -91,6 +93,8 @@ struct sbi_scratch {
> >         unsigned long options;
> >         /** Index of the hart */
> >         unsigned long hartindex;
> > +       /** Address of the expected trap handler for this HART */
> > +       unsigned long expected_trap;
>
> Instead of adding in struct sbi_scratch please add this to
> struct sbi_hart_features.
>
> Typically, we add stuff to struct sbi_scratch only when we
> expect it to be accessed by low-level assembly entry/exit
> routines.

Thanks!

I'll move the handler into struct sbi_hart_features in v6 and drop the
scratch layout and allocator changes

-- 
Troy Mitchell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 105 bytes --]

-- 
opensbi mailing list
opensbi@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi