OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yu-Chien Peter Lin <peterlin@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 1/4] platform: generic/andes: Enable generic platform support for AE350
Date: Mon, 28 Nov 2022 20:28:42 +0000	[thread overview]
Message-ID: <Y4UZ+rcUBTUG152q@APC323> (raw)
In-Reply-To: <CA+V-a8urkMz-Fwj9OFLEp2FAYG9_ZpFG9S_QBNK1=zR1g4svFg@mail.gmail.com>

On Mon, Nov 28, 2022 at 10:34:06AM +0000, Lad, Prabhakar wrote:
> Hi Lin-san,
> 
> On Mon, Nov 28, 2022 at 8:32 AM Yu Chien Peter Lin
> <peterlin@andestech.com> wrote:
> >
> > We move andes directory to platform/generic since the necessary fdt
> > drivers are available, the users can enable the console, timer, ipi,
> > irqchip and reset devices by adding device tree nodes stated in the
> > docs/platform/andes-ae350.md.
> >
> > Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> > ---
> > Although generic/platform.c has been able to boot the system
> > on AE350, we will add HSM device for it soon so let's keep
> > ae350.c as a placeholder.
> > ---
> >  platform/andes/ae350/Kconfig           |  34 -----
> >  platform/andes/ae350/cache.c           |  89 -------------
> >  platform/andes/ae350/cache.h           |  17 ---
> >  platform/andes/ae350/configs/defconfig |   0
> >  platform/andes/ae350/objects.mk        |  40 ------
> >  platform/andes/ae350/platform.c        | 169 -------------------------
> >  platform/andes/ae350/platform.h        | 109 ----------------
> >  platform/generic/Kconfig               |   4 +
> >  platform/generic/andes/ae350.c         |  21 +++
> >  platform/generic/andes/objects.mk      |   6 +
> >  platform/generic/configs/defconfig     |   4 +
> >  11 files changed, 35 insertions(+), 458 deletions(-)
> >  delete mode 100644 platform/andes/ae350/Kconfig
> >  delete mode 100644 platform/andes/ae350/cache.c
> >  delete mode 100644 platform/andes/ae350/cache.h
> You have got rid of cache functions and also the vendor specific EXT
> handler, wouldn't that break things?

Hi Prabhakar,

I want to take this opportunity to drop unnecessary functions, most of
the andes SBI calls were experimental/debugging features in kernel that
won't affact the boot flow.

You can still keep them in generic/renesas/rzfive.c. The renesas vendor
SBI call fid does not need to be the same as ours.

As for common Andes CSR which you separated into andes/ae350/common-platform.h
can be moved to generic/include/andes45.h.

Best regards,
Peter Lin

> Cheers,
> Prabhakar


  reply	other threads:[~2022-11-28 20:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28  8:30 [PATCH 0/4] Enable generic platform support for AE350 Yu Chien Peter Lin
2022-11-28  8:30 ` [PATCH 1/4] platform: generic/andes: " Yu Chien Peter Lin
2022-11-28 10:34   ` Lad, Prabhakar
2022-11-28 20:28     ` Yu-Chien Peter Lin [this message]
2022-11-30 12:40       ` Lad, Prabhakar
2022-12-02 16:10   ` Bin Meng
2022-11-28  8:30 ` [PATCH 2/4] docs: platform: Update AE350 and generic platform documentation Yu Chien Peter Lin
2022-12-02 16:10   ` Bin Meng
2022-12-05  9:38     ` Yu-Chien Peter Lin
2022-11-28  8:30 ` [PATCH 3/4] docs: andes-ae350.md: fix watchdog nodename in dts example Yu Chien Peter Lin
2022-12-02 16:10   ` Bin Meng
2022-11-28  8:30 ` [PATCH 4/4] scripts/create-binary-archive.sh: remove andes/ae350 build directory Yu Chien Peter Lin
2022-12-02 16:10   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4UZ+rcUBTUG152q@APC323 \
    --to=peterlin@andestech.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox