From: Yu-Chien Peter Lin <peterlin@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 6/6] lib: sbi_hsm: Introduce hart_secondary_boot() callback
Date: Mon, 16 Jan 2023 20:15:29 +0000 [thread overview]
Message-ID: <Y8WwYeF/oievzNwn@APC323> (raw)
In-Reply-To: <CAAhSdy3B8vi2DQ7Caa-i=VFELvYnh=aZZV+7fNKtmcnehi3WkA@mail.gmail.com>
Hi Anup,
On Mon, Jan 16, 2023 at 02:48:46PM +0530, Anup Patel wrote:
> On Sun, Jan 8, 2023 at 6:40 PM Yu-Chien Peter Lin
> <peterlin@andestech.com> wrote:
> >
> > Hi Andrew,
> >
> > On Fri, Jan 06, 2023 at 03:29:46PM +0100, Andrew Jones wrote:
> > > On Wed, Jan 04, 2023 at 02:29:27PM +0800, Yu Chien Peter Lin wrote:
> > > > When platform supports hotplug, i.e. both hart_start() and hart_stop()
> > > > callbacks are provided, the former doesn't need to be performed at
> > > > the boot-time. Thus, add a callback for the case of secondary boot.
> > > >
> > > > Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
> > > > ---
> > > > include/sbi/sbi_hsm.h | 7 +++++++
> > > > lib/sbi/sbi_hsm.c | 22 +++++++++++++---------
> > > > 2 files changed, 20 insertions(+), 9 deletions(-)
> > >
> > > I'm not sure why this patch is in the series as the change isn't used.
> > >
> > > Thanks,
> > > drew
> >
> > Thanks for the review.
> >
> > I'm just found it's not necessary to run platform-specific hart_start()
> > at boot-time since it's for CPU hotplug, I'm not sure hart_start() is
> > supposed to do at boot-time so we can ignore this patch if it's not worth
> > adding a callback.
>
> For now it looks like we don't need this callback but we can revisit
> in the future.
>
> Regards,
> Anup
>
Thanks for the review, I will drop this callback.
Best regards,
Peter Lin
prev parent reply other threads:[~2023-01-16 20:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 6:29 [PATCH 0/6] Implement hart hotplug using HSM extension for Yu Chien Peter Lin
2023-01-04 6:29 ` [PATCH 1/6] docs: generic.md: fix typo of andes-ae350 Yu Chien Peter Lin
2023-01-16 9:00 ` Anup Patel
2023-01-04 6:29 ` [PATCH 2/6] lib: sbi_hsm: handle failure when hart_stop returns SBI_ENOTSUPP Yu Chien Peter Lin
2023-01-06 13:40 ` Andrew Jones
2023-01-09 9:08 ` Atish Patra
2023-01-16 9:01 ` Anup Patel
2023-01-04 6:29 ` [PATCH 3/6] include: types: add always inline compiler attribute Yu Chien Peter Lin
2023-01-16 9:02 ` Anup Patel
2023-01-04 6:29 ` [PATCH 4/6] platform: andes/ae350: Implement hart hotplug using HSM extension Yu Chien Peter Lin
2023-01-16 9:09 ` Anup Patel
2023-01-04 6:29 ` [PATCH 5/6] lib: reset/fdt_reset_atcwdt200: use defined macros in atcsmu.h Yu Chien Peter Lin
2023-01-16 9:15 ` Anup Patel
2023-01-16 20:17 ` Yu-Chien Peter Lin
2023-01-04 6:29 ` [PATCH 6/6] lib: sbi_hsm: Introduce hart_secondary_boot() callback Yu Chien Peter Lin
2023-01-06 14:29 ` Andrew Jones
2023-01-08 21:09 ` Yu-Chien Peter Lin
2023-01-16 9:18 ` Anup Patel
2023-01-16 20:15 ` Yu-Chien Peter Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8WwYeF/oievzNwn@APC323 \
--to=peterlin@andestech.com \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox