OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yu-Chien Peter Lin <peterlin@andestech.com>
To: opensbi@lists.infradead.org
Subject: [PATCH 3/6] platform: andes: Add Andes custom PMU support
Date: Fri, 22 Sep 2023 08:58:23 +0800	[thread overview]
Message-ID: <ZQzmrtt5861O6n5H@APC323> (raw)
In-Reply-To: <ZQvXaQ842WGRNH1W@APC323>

> > > +               sbi_pmu_set_device(&andes_pmu);
> > In my opinion we might want to append the PMU node to DT here
> 
> Sure, I will add fdt fixup so RZ/Five users won't need to manually
> append the PMU node.
> 
> > and pass that DT fragment to the higher stack instead of adding it in Linux.
> 
> The PMU node is not visible to S-mode SW (U-Boot proper or Linux) since
> it is only used to initialize the event counter mappings and erased in
> the generic_final_init() [2].

Sorry. It should be said that part of it (riscv,*event-to-mhpm* properties)
will be erased, not the entire node.

the higher stack can still find the pmu node:

  pmu {
      compatible = "riscv,pmu";
  }

> Thanks,
> Peter Lin
> 
> [1] https://github.com/riscv-software-src/opensbi/blob/v1.3.1/lib/sbi/sbi_pmu.c#L583
> [2] https://github.com/riscv-software-src/opensbi/blob/master/platform/generic/platform.c#L172
> 


  reply	other threads:[~2023-09-22  0:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-06  9:40 [PATCH 0/6] Add Andes PMU extension support Yu Chien Peter Lin
2023-09-06  9:40 ` [PATCH 1/6] sbi: sbi_pmu: Add hw_counter_filter_mode() to pmu device Yu Chien Peter Lin
2023-09-06  9:40 ` [PATCH 2/6] platform: include: andes45: Add PMU related CSR defines Yu Chien Peter Lin
2023-09-06  9:40 ` [PATCH 3/6] platform: andes: Add Andes custom PMU support Yu Chien Peter Lin
2023-09-18 14:03   ` Lad, Prabhakar
2023-09-18 19:12     ` Conor Dooley
2023-09-21  5:40     ` Yu-Chien Peter Lin
2023-09-22  0:58       ` Yu-Chien Peter Lin [this message]
2023-09-06  9:40 ` [PATCH 4/6] platform: andes: Enable Andes PMU for AE350 Yu Chien Peter Lin
2023-09-06  9:40 ` [PATCH 5/6] platform: rzfive: Enable Andes PMU for RZ/Five Yu Chien Peter Lin
2023-09-06  9:40 ` [PATCH 6/6] docs: pmu: Add Andes PMU node example Yu Chien Peter Lin
2023-10-06 12:17 ` [PATCH 0/6] Add Andes PMU extension support Anup Patel
2023-10-07  6:04   ` Yu-Chien Peter Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZQzmrtt5861O6n5H@APC323 \
    --to=peterlin@andestech.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox