OpenSBI Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Xiang W <wxjstz@126.com>
To: opensbi@lists.infradead.org
Subject: [PATCH v2] scripts: use env to invoke bash
Date: Fri, 09 Dec 2022 17:11:34 +0800	[thread overview]
Message-ID: <bb27feef21e1ca3d3e4b843400a6df03f85e5592.camel@126.com> (raw)
In-Reply-To: <20221209061335.1326839-1-hchauhan@ventanamicro.com>

? 2022-12-09???? 11:43 +0530?Himanshu Chauhan???
> Not all systems have bash at a fixed location like /bin/bash.
> FreeBSD, for example, would typically have it at /usr/local/bin/bash.
> When building OpenSBI on freebsd system, the build breaks.
> 
> Its advisable to use: #!/usr/bin/env bash
> 
> [v2] In this version:
> * Change remaining two scripts to use env
> 
> Signed-off-by: Himanshu Chauhan <hchauhan@ventanamicro.com>
LGTM

Reviewed-by: Xiang W <wxjstz@126.com>
> ---
> ?scripts/carray.sh??????????????? | 2 +-
> ?scripts/create-binary-archive.sh | 2 +-
> ?scripts/d2c.sh?????????????????? | 2 +-
> ?3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/carray.sh b/scripts/carray.sh
> index 0c52bd6..13f9d36 100755
> --- a/scripts/carray.sh
> +++ b/scripts/carray.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> ?
> ?function usage()
> ?{
> diff --git a/scripts/create-binary-archive.sh b/scripts/create-binary-archive.sh
> index 261a45a..63781e1 100755
> --- a/scripts/create-binary-archive.sh
> +++ b/scripts/create-binary-archive.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> ?
> ?function usage()
> ?{
> diff --git a/scripts/d2c.sh b/scripts/d2c.sh
> index 33a3ccf..c411fcd 100755
> --- a/scripts/d2c.sh
> +++ b/scripts/d2c.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/usr/bin/env bash
> ?
> ?function usage()
> ?{
> -- 
> 2.38.1
> 
> 




  reply	other threads:[~2022-12-09  9:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-09  6:13 [PATCH v2] scripts: use env to invoke bash Himanshu Chauhan
2022-12-09  9:11 ` Xiang W [this message]
2022-12-10 16:24 ` Anup Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bb27feef21e1ca3d3e4b843400a6df03f85e5592.camel@126.com \
    --to=wxjstz@126.com \
    --cc=opensbi@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox