From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schwab Date: Wed, 20 Mar 2024 15:57:58 +0100 Subject: [PATCH] lib: sbi: Add missing sscrind and sscfg extensions in sbi_hart_ext[] In-Reply-To: <20240320145051.1459406-1-cleger@rivosinc.com> (=?utf-8?Q?=22?= =?utf-8?Q?Cl=C3=A9ment_L=C3=A9ger=22's?= message of "Wed, 20 Mar 2024 15:50:43 +0100") References: <20240320145051.1459406-1-cleger@rivosinc.com> Message-ID: List-Id: To: opensbi@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On M?r 20 2024, Cl?ment L?ger wrote: > The sbi_hart_ext[] array is missing these two extensions ids. It is > expected that this array contains all the extensions declaration at the > same index of the SBI_HART_EXT_* define. Without this, when adding a new > extension, there is a mismatch between ids and extension names and it > can even display corrupted extension names. > > Signed-off-by: Cl?ment L?ger > > --- > lib/sbi/sbi_hart.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/sbi/sbi_hart.c b/lib/sbi/sbi_hart.c > index 3d13694..d68e2a0 100644 > --- a/lib/sbi/sbi_hart.c > +++ b/lib/sbi/sbi_hart.c > @@ -666,6 +666,8 @@ const struct sbi_hart_ext_data sbi_hart_ext[] = { > __SBI_HART_EXT_DATA(sdtrig, SBI_HART_EXT_SDTRIG), > __SBI_HART_EXT_DATA(smcsrind, SBI_HART_EXT_SMCSRIND), > __SBI_HART_EXT_DATA(smcdeleg, SBI_HART_EXT_SMCDELEG), > + __SBI_HART_EXT_DATA(sscsrind, SBI_HART_EXT_SSCSRIND), > + __SBI_HART_EXT_DATA(ssccfg, SBI_HART_EXT_SSCCFG), > }; Please add a static_assert to verify that the size of sbi_hart_ext agrees with SBI_HART_EXT_MAX. -- Andreas Schwab, SUSE Labs, schwab at suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."