From: Andreas Schwab <schwab@suse.de>
To: opensbi@lists.infradead.org
Subject: [PATCH] lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers
Date: Mon, 28 Nov 2022 14:36:24 +0100 [thread overview]
Message-ID: <mvmpmd78alj.fsf@suse.de> (raw)
In-Reply-To: <20221128132129.58558-1-bmeng@tinylab.org> (Bin Meng's message of "Mon, 28 Nov 2022 21:21:29 +0800")
On Nov 28 2022, Bin Meng wrote:
> diff --git a/lib/utils/irqchip/plic.c b/lib/utils/irqchip/plic.c
> index 73d7788..4df9020 100644
> --- a/lib/utils/irqchip/plic.c
> +++ b/lib/utils/irqchip/plic.c
> @@ -38,13 +38,13 @@ static void plic_set_priority(const struct plic_data *plic, u32 source, u32 val)
>
> void plic_priority_save(const struct plic_data *plic, u8 *priority)
> {
> - for (u32 i = 0; i < plic->num_src; i++)
> + for (u32 i = 1; i <= plic->num_src; i++)
> priority[i] = plic_get_priority(plic, i);
That requires updating the size of the priority array.
--
Andreas Schwab, SUSE Labs, schwab at suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2022-11-28 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 13:21 [PATCH] lib: utils/irqchip: plic: Fix the off-by-one error in priority save/restore helpers Bin Meng
2022-11-28 13:36 ` Andreas Schwab [this message]
2022-11-28 13:50 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmpmd78alj.fsf@suse.de \
--to=schwab@suse.de \
--cc=opensbi@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox