Outreachy Linux Kernel Community
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Sowmya Torra <sowmyatorra@gmail.com>
Cc: outreachy@lists.linux.dev, julianbraha@gmail.com,
	Julia Lawall <julia.lawall@inria.fr>
Subject: Re: Investigating unused SCSI zone tracepoints
Date: Sun, 25 Oct 2026 09:51:38 -0400	[thread overview]
Message-ID: <20261025095138.3bca1822@fedora> (raw)
In-Reply-To: <CAFsBPPndmdUMYbiq98qmeBJ_fbYFCNxRngxxx4jB3JHg-G-02g@mail.gmail.com>

On Sun, 25 Oct 2026 17:13:13 +0530
Sowmya Torra <sowmyatorra@gmail.com> wrote:

> Hello everyone,
> 
> While building the kernel with UT=1 using the provided configuration,
> I came across two unused SCSI tracepoint warnings:
> 
> scsi_prepare_zone_append
> scsi_zone_wp_update
> 
> I decided to investigate why these tracepoints were no longer being used.
> 
> After tracing their references and looking through the Git history, I
> found that commit 1846f308d66f ("scsi: sd: Use the block layer zone
> append emulation") removed both tracepoint calls when zone append
> emulation was moved to the block layer.
> 
> However, their definitions still remain in drivers/scsi/sd_trace.h,
> and sd_zbc.c continues to include this header with
> CREATE_TRACE_POINTS.
> 
> I also searched the repository for both tracepoints and couldn't find
> any remaining callers. Additionally, I checked the compiled sd_zbc.o
> and found that code and data for these unused events are still being
> generated.
> 
> Based on these findings, I believe removing the obsolete tracepoint
> definitions, along with the unused header and its inclusion, would be
> a useful cleanup. I plan to rebuild with UT=1 afterward to verify that
> the warnings are resolved.
> I plan to work on this cleanup. Please let me know if it overlaps with
> an existing effort.
> I'd appreciate any feedback on my investigation and the proposed
> approach before I proceed with the patch.

Everything you mention above sounds appropriate. I look forward to the
patch you produce to clean this up.

-- Steve

      reply	other threads:[~2026-10-25 13:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-25 11:43 Investigating unused SCSI zone tracepoints Sowmya Torra
2026-10-25 13:51 ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261025095138.3bca1822@fedora \
    --to=rostedt@goodmis.org \
    --cc=julia.lawall@inria.fr \
    --cc=julianbraha@gmail.com \
    --cc=outreachy@lists.linux.dev \
    --cc=sowmyatorra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox