From: Steven Rostedt <rostedt@goodmis.org>
To: pavankumaryalagada@gmail.com
Cc: outreachy@lists.linux.dev, julianbraha@gmail.com
Subject: Re: [PATCH v3] nfs: Only define atomic open tracepoints when NFSv4 is enabled
Date: Sat, 7 Nov 2026 16:53:18 -0500 [thread overview]
Message-ID: <20261107165318.6bc5a2d1@fedora> (raw)
In-Reply-To: <20261101000843.188761-1-pavankumaryalagada@gmail.com>
On Sun, 1 Nov 2026 05:38:43 +0530
pavankumaryalagada@gmail.com wrote:
> From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
>
> Tracepoint definitions consume kernel memory even when they are not
> used. When tracepoints are only used in code compiled under a specific
> configuration, their definitions should also be guarded by the same
> configuration to avoid wasting memory.
>
> The nfs_atomic_open_enter and nfs_atomic_open_exit tracepoints are
> only used in nfs_atomic_open() in fs/nfs/dir.c, which is compiled
> only when CONFIG_NFS_V4 is enabled. Guard their definitions with
Could you reword the above slightly, as I read the "which is complied"
to be fs/nfs/dir.c and not the function. Perhaps just remove the "in
fs/nfs/dir.c" part. The nfs_atomic_open() should be unique enough to
know where the issue is.
Thanks,
-- Steve
> the same config to avoid unused tracepoints and reduce memory usage
> by approximately 8 KiB.
>
> Fixes: 6e0d0be715fe ("NFS: Add event tracing for generic NFS lookups")
> Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
prev parent reply other threads:[~2026-11-07 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-01 0:08 [PATCH v3] nfs: Only define atomic open tracepoints when NFSv4 is enabled pavankumaryalagada
2026-11-07 21:53 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261107165318.6bc5a2d1@fedora \
--to=rostedt@goodmis.org \
--cc=julianbraha@gmail.com \
--cc=outreachy@lists.linux.dev \
--cc=pavankumaryalagada@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox