Re: Coccinelle based patch processing

[Deepak R Varma <drv@mailo.com>]

On Tue, Nov 01, 2022 at 03:34:52PM +0100, Julia Lawall wrote:
>
>
> On Tue, 1 Nov 2022, Deepak R Varma wrote:
>
> > Hello,
> > I have a coccicheck produced patch [attached here] using the following command.
> > Can you please suggest how to submit this as a patch? Is there a document that I
> > can follow to accomplish the submission?
> >
> >    make coccicheck COCCI=./scripts/coccinelle/misc/returnvar.cocci M=driver/staging/r8188eu/ MODE=patch
>
> Do what you would have done if you had made the patch by hand.
You mean:
   1) review and implement the patch suggested changes manually onto my local
   patch branch
   2) build
   3) commit
   4) generate and send patch using mutt format-patch

Or is simply do a "mutt -H cocci-auto.patch" and add the subject and patch log
at the time of compiling the email?

In the later case, I am not building the driver to ensure the changes are
accurate.

Can you please comment.

>
> If the changes are quite identical, then you can group changes on multiple
> files into one.
>
> But in this case, even though all the changes do the same thing, it may
> not be a good idea to group them, because the context is different in each
> case.  In particular, you should check each case to see whether the return
> variable really was unnecessary, or whether it actually was necessary, and
> the developer forgot to set it to something.

Okay. I will review this once again before submitting the patch(es).

./drv

>
> julia
>
>
> >
> > Thank you,
> > ./drv
> >
>