From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Samuel Abraham <abrahamadekunle50@gmail.com>
Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
julia.lawall@inria.fr, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, david.laight.linux@gmail.com,
dan.carpenter@linaro.org
Subject: Re: [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators
Date: Tue, 8 Apr 2025 12:35:05 +0300 [thread overview]
Message-ID: <Z_TtyXwkOBK1MXGy@smile.fi.intel.com> (raw)
In-Reply-To: <CADYq+fbh=kG2JABmdF8FjjPiyigMpnJ7WhQh+faqRk6FJe4MBQ@mail.gmail.com>
On Tue, Apr 08, 2025 at 10:22:44AM +0100, Samuel Abraham wrote:
> On Tue, Apr 8, 2025 at 8:20 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Tue, Apr 8, 2025 at 12:54 AM Abraham Samuel Adekunle
> > <abrahamadekunle50@gmail.com> wrote:
...
> > > - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> > > + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) & 0xfff;
> >
> > > - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> > > + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) & 0xfff;
> >
> > You mentioned Linux coding style, which also requires lines not to be
> > so long. These lines are. That's why a few versions ago I suggested
> > you to change these to be two lines each. I don't know how many times
> > to repeat this (it's third one).
>
> Okay, sorry
> I will add a third patch for a line break before the patch for %
> operations since each patch should handle a single thing.
I am not sure you need a third patch for that. It lies into category of space
and indentation fix.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-04-08 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 21:53 [PATCH v6 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping Abraham Samuel Adekunle
2025-04-07 21:53 ` [PATCH v6 1/2] staging: rtl8723bs: Add white spaces around binary operators Abraham Samuel Adekunle
2025-04-08 7:19 ` Andy Shevchenko
2025-04-08 9:22 ` Samuel Abraham
2025-04-08 9:35 ` Andy Shevchenko [this message]
2025-04-08 10:15 ` Dan Carpenter
2025-04-08 11:51 ` Samuel Abraham
2025-04-08 12:38 ` Dan Carpenter
2025-04-08 12:53 ` Samuel Abraham
2025-04-07 21:53 ` [PATCH v6 2/2] staging: rtl8723bs: Use % 4096u instead of & 0xfff Abraham Samuel Adekunle
2025-04-08 7:20 ` [PATCH v6 0/2] staging: rtl8723bs: Improve readability and clarity of sequence number wrapping Andy Shevchenko
2025-04-08 9:28 ` Samuel Abraham
2025-04-08 9:36 ` Andy Shevchenko
2025-04-08 11:46 ` Samuel Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_TtyXwkOBK1MXGy@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=abrahamadekunle50@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=david.laight.linux@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox