* [PATCH v4 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list
2024-03-25 17:47 [PATCH v4 0/3] staging: rtl8712: Trivial code cleanup patches Ayush Tiwari
@ 2024-03-25 17:49 ` Ayush Tiwari
2024-03-25 17:50 ` [PATCH v4 2/3] staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index Ayush Tiwari
2024-03-25 17:52 ` [PATCH v4 3/3] staging: rtl8712: rename backupTKIPCountermeasure to backup_TKIP_countermeasure Ayush Tiwari
2 siblings, 0 replies; 4+ messages in thread
From: Ayush Tiwari @ 2024-03-25 17:49 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename backupPMKIDList to backup_PMKID_list and remove extra spaces
between RT_PMKID_LIST and backupPMKIDList to address checkpatch
warnings and match the common kernel coding style.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
v4: Update the changelog to match revision history
v3: Update memcpy() param to match new name backup_PMKID_list
v2: No changes. Just a patch sending error.
drivers/staging/rtl8712/mlme_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index b9f5104f3bf7..a009ec1a5c11 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -84,7 +84,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
netif_carrier_on(adapter->pnetdev);
}
-static struct RT_PMKID_LIST backupPMKIDList[NUM_PMKID_CACHE];
+static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
u8 backupPMKIDIndex = 0;
@@ -99,7 +99,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
* disconnect with AP for 60 seconds.
*/
- memcpy(&backupPMKIDList[0],
+ memcpy(&backup_PMKID_list[0],
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
backupPMKIDIndex = adapter->securitypriv.PMKIDIndex;
@@ -113,7 +113,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
* for the following connection.
*/
memcpy(&adapter->securitypriv.PMKIDList[0],
- &backupPMKIDList[0],
+ &backup_PMKID_list[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
adapter->securitypriv.PMKIDIndex = backupPMKIDIndex;
adapter->securitypriv.btkip_countermeasure =
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v4 2/3] staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index
2024-03-25 17:47 [PATCH v4 0/3] staging: rtl8712: Trivial code cleanup patches Ayush Tiwari
2024-03-25 17:49 ` [PATCH v4 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list Ayush Tiwari
@ 2024-03-25 17:50 ` Ayush Tiwari
2024-03-25 17:52 ` [PATCH v4 3/3] staging: rtl8712: rename backupTKIPCountermeasure to backup_TKIP_countermeasure Ayush Tiwari
2 siblings, 0 replies; 4+ messages in thread
From: Ayush Tiwari @ 2024-03-25 17:50 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename variable backupPMKIDIndex to backup_PMKID_index to address
checkpatch warning 'Avoid Camelcase' and to ensure adherence to
coding style guidelines.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
Changes in v4: No change
Changes in v3: No change
Changes in v2: No change
drivers/staging/rtl8712/mlme_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index a009ec1a5c11..ac8196d24ce0 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -87,7 +87,7 @@ void r8712_os_indicate_connect(struct _adapter *adapter)
static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
- u8 backupPMKIDIndex = 0;
+ u8 backup_PMKID_index = 0;
u8 backupTKIPCountermeasure = 0x00;
r8712_indicate_wx_disassoc_event(adapter);
@@ -102,7 +102,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
memcpy(&backup_PMKID_list[0],
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
- backupPMKIDIndex = adapter->securitypriv.PMKIDIndex;
+ backup_PMKID_index = adapter->securitypriv.PMKIDIndex;
backupTKIPCountermeasure =
adapter->securitypriv.btkip_countermeasure;
memset((unsigned char *)&adapter->securitypriv, 0,
@@ -115,7 +115,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
memcpy(&adapter->securitypriv.PMKIDList[0],
&backup_PMKID_list[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
- adapter->securitypriv.PMKIDIndex = backupPMKIDIndex;
+ adapter->securitypriv.PMKIDIndex = backup_PMKID_index;
adapter->securitypriv.btkip_countermeasure =
backupTKIPCountermeasure;
} else { /*reset values in securitypriv*/
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH v4 3/3] staging: rtl8712: rename backupTKIPCountermeasure to backup_TKIP_countermeasure
2024-03-25 17:47 [PATCH v4 0/3] staging: rtl8712: Trivial code cleanup patches Ayush Tiwari
2024-03-25 17:49 ` [PATCH v4 1/3] staging: rtl8712: rename backupPMKIDList to backup_PMKID_list Ayush Tiwari
2024-03-25 17:50 ` [PATCH v4 2/3] staging: rtl8712: rename backupPMKIDIndex to backup_PMKID_index Ayush Tiwari
@ 2024-03-25 17:52 ` Ayush Tiwari
2 siblings, 0 replies; 4+ messages in thread
From: Ayush Tiwari @ 2024-03-25 17:52 UTC (permalink / raw)
To: Larry.Finger, florian.c.schilhabel, gregkh, linux-kernel,
linux-staging
Cc: outreachy
Rename variable backupTKIPCountermeasure to backup_TKIP_countermeasure
to address checkpatch warning 'Avoid Camelcase' and to ensure
adherence to coding style guidelines.
Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com>
---
Changes in v4: No change
Changes in v3: No change
Changes in v2: No change
drivers/staging/rtl8712/mlme_linux.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8712/mlme_linux.c b/drivers/staging/rtl8712/mlme_linux.c
index ac8196d24ce0..436816d14cdf 100644
--- a/drivers/staging/rtl8712/mlme_linux.c
+++ b/drivers/staging/rtl8712/mlme_linux.c
@@ -88,7 +88,7 @@ static struct RT_PMKID_LIST backup_PMKID_list[NUM_PMKID_CACHE];
void r8712_os_indicate_disconnect(struct _adapter *adapter)
{
u8 backup_PMKID_index = 0;
- u8 backupTKIPCountermeasure = 0x00;
+ u8 backup_TKIP_countermeasure = 0x00;
r8712_indicate_wx_disassoc_event(adapter);
netif_carrier_off(adapter->pnetdev);
@@ -103,7 +103,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
&adapter->securitypriv.PMKIDList[0],
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
backup_PMKID_index = adapter->securitypriv.PMKIDIndex;
- backupTKIPCountermeasure =
+ backup_TKIP_countermeasure =
adapter->securitypriv.btkip_countermeasure;
memset((unsigned char *)&adapter->securitypriv, 0,
sizeof(struct security_priv));
@@ -117,7 +117,7 @@ void r8712_os_indicate_disconnect(struct _adapter *adapter)
sizeof(struct RT_PMKID_LIST) * NUM_PMKID_CACHE);
adapter->securitypriv.PMKIDIndex = backup_PMKID_index;
adapter->securitypriv.btkip_countermeasure =
- backupTKIPCountermeasure;
+ backup_TKIP_countermeasure;
} else { /*reset values in securitypriv*/
struct security_priv *sec_priv = &adapter->securitypriv;
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread