* [PATCH v2 1/8] staging: sm750fb: change sii164GetDeviceID to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 2/8] staging: sm750fb: change sii164ResetChip " Richard Akintola
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164GetDeviceID to sii164_get_device_id
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetDeviceID>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 6 +++---
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 8b81e8642f9e..3fb14eff2de1 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -16,7 +16,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
{
.init = sii164_init_chip,
.get_vendor_id = sii164_get_vendor_id,
- .get_device_id = sii164GetDeviceID,
+ .get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
.reset_chip = sii164ResetChip,
.get_chip_string = sii164GetChipString,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 2532b60245ac..223c181dc649 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -48,13 +48,13 @@ unsigned short sii164_get_vendor_id(void)
}
/*
- * sii164GetDeviceID
+ * sii164_get_device_id
* This function gets the device ID of the DVI controller chip.
*
* Output:
* Device ID
*/
-unsigned short sii164GetDeviceID(void)
+unsigned short sii164_get_device_id(void)
{
unsigned short deviceID;
@@ -141,7 +141,7 @@ long sii164_init_chip(unsigned char edge_select,
/* Check if SII164 Chip exists */
if ((sii164_get_vendor_id() == SII164_VENDOR_ID) &&
- (sii164GetDeviceID() == SII164_DEVICE_ID)) {
+ (sii164_get_device_id() == SII164_DEVICE_ID)) {
/*
* Initialize SII164 controller chip.
*/
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 71a7c1cb42c4..a76091f6622b 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -28,7 +28,7 @@ long sii164_init_chip(unsigned char edgeSelect,
unsigned char pllFilterValue);
unsigned short sii164_get_vendor_id(void);
-unsigned short sii164GetDeviceID(void);
+unsigned short sii164_get_device_id(void);
#ifdef SII164_FULL_FUNCTIONS
void sii164ResetChip(void);
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 2/8] staging: sm750fb: change sii164ResetChip to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
2025-04-08 10:20 ` [PATCH v2 1/8] staging: sm750fb: change sii164GetDeviceID to snake_case Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 3/8] staging: sm750fb: change sii164SetPower " Richard Akintola
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164ResetChip to sii164_reset_chip
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ResetChip>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 3fb14eff2de1..6dee95e60a6e 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -18,7 +18,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.get_vendor_id = sii164_get_vendor_id,
.get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
- .reset_chip = sii164ResetChip,
+ .reset_chip = sii164_reset_chip,
.get_chip_string = sii164GetChipString,
.set_power = sii164SetPower,
.enable_hot_plug_detection = sii164EnableHotPlugDetection,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 223c181dc649..284c32f7e9b4 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -250,10 +250,10 @@ long sii164_init_chip(unsigned char edge_select,
#ifdef SII164_FULL_FUNCTIONS
/*
- * sii164ResetChip
+ * sii164_reset_chip
* This function resets the DVI Controller Chip.
*/
-void sii164ResetChip(void)
+void sii164_reset_chip(void)
{
/* Power down */
sii164SetPower(0);
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index a76091f6622b..7a71f94a1e9b 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -31,7 +31,7 @@ unsigned short sii164_get_vendor_id(void);
unsigned short sii164_get_device_id(void);
#ifdef SII164_FULL_FUNCTIONS
-void sii164ResetChip(void);
+void sii164_reset_chip(void);
char *sii164GetChipString(void);
void sii164SetPower(unsigned char powerUp);
void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 3/8] staging: sm750fb: change sii164SetPower to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
2025-04-08 10:20 ` [PATCH v2 1/8] staging: sm750fb: change sii164GetDeviceID to snake_case Richard Akintola
2025-04-08 10:20 ` [PATCH v2 2/8] staging: sm750fb: change sii164ResetChip " Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 4/8] staging: sm750fb: change sii164GetChipString " Richard Akintola
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164SetPower to sii164_set_power
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164SetPower>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++----
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 6dee95e60a6e..bb7538682b7d 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -20,7 +20,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
#ifdef SII164_FULL_FUNCTIONS
.reset_chip = sii164_reset_chip,
.get_chip_string = sii164GetChipString,
- .set_power = sii164SetPower,
+ .set_power = sii164_set_power,
.enable_hot_plug_detection = sii164EnableHotPlugDetection,
.is_connected = sii164IsConnected,
.check_interrupt = sii164CheckInterrupt,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 284c32f7e9b4..b96f9369fab4 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -256,8 +256,8 @@ long sii164_init_chip(unsigned char edge_select,
void sii164_reset_chip(void)
{
/* Power down */
- sii164SetPower(0);
- sii164SetPower(1);
+ sii164_set_power(0);
+ sii164_set_power(1);
}
/*
@@ -273,13 +273,13 @@ char *sii164GetChipString(void)
}
/*
- * sii164SetPower
+ * sii164_set_power
* This function sets the power configuration of the DVI Controller Chip.
*
* Input:
* powerUp - Flag to set the power down or up
*/
-void sii164SetPower(unsigned char powerUp)
+void sii164_set_power(unsigned char powerUp)
{
unsigned char config;
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 7a71f94a1e9b..45a90489c95c 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -33,7 +33,7 @@ unsigned short sii164_get_device_id(void);
#ifdef SII164_FULL_FUNCTIONS
void sii164_reset_chip(void);
char *sii164GetChipString(void);
-void sii164SetPower(unsigned char powerUp);
+void sii164_set_power(unsigned char powerUp);
void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
unsigned char sii164IsConnected(void);
unsigned char sii164CheckInterrupt(void);
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 4/8] staging: sm750fb: change sii164GetChipString to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
` (2 preceding siblings ...)
2025-04-08 10:20 ` [PATCH v2 3/8] staging: sm750fb: change sii164SetPower " Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 5/8] staging: sm750fb: change sii164EnableHotPlugDetection " Richard Akintola
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164GetChipString to sii164_get_chip_string
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164GetChipString>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index bb7538682b7d..c12df1f9fb00 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -19,7 +19,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.get_device_id = sii164_get_device_id,
#ifdef SII164_FULL_FUNCTIONS
.reset_chip = sii164_reset_chip,
- .get_chip_string = sii164GetChipString,
+ .get_chip_string = sii164_get_chip_string,
.set_power = sii164_set_power,
.enable_hot_plug_detection = sii164EnableHotPlugDetection,
.is_connected = sii164IsConnected,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index b96f9369fab4..d0b80b86a4d7 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -261,13 +261,13 @@ void sii164_reset_chip(void)
}
/*
- * sii164GetChipString
+ * sii164_get_chip_string
* This function returns a char string name of the current DVI Controller
* chip.
*
* It's convenient for application need to display the chip name.
*/
-char *sii164GetChipString(void)
+char *sii164_get_chip_string(void)
{
return gDviCtrlChipName;
}
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 45a90489c95c..c15cd6a5d53b 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -32,7 +32,7 @@ unsigned short sii164_get_device_id(void);
#ifdef SII164_FULL_FUNCTIONS
void sii164_reset_chip(void);
-char *sii164GetChipString(void);
+char *sii164_get_chip_string(void);
void sii164_set_power(unsigned char powerUp);
void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
unsigned char sii164IsConnected(void);
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 5/8] staging: sm750fb: change sii164EnableHotPlugDetection to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
` (3 preceding siblings ...)
2025-04-08 10:20 ` [PATCH v2 4/8] staging: sm750fb: change sii164GetChipString " Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 6/8] staging: sm750fb: change sii164IsConnected " Richard Akintola
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164EnableHotPlugDetection to sii164_enable_hot_plug_detection
and it's parameter enableHotPlug to enable_hot_plug
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164EnableHotPlugDetection>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 8 ++++----
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index c12df1f9fb00..1ce44c50617a 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -21,7 +21,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.reset_chip = sii164_reset_chip,
.get_chip_string = sii164_get_chip_string,
.set_power = sii164_set_power,
- .enable_hot_plug_detection = sii164EnableHotPlugDetection,
+ .enable_hot_plug_detection = sii164_enable_hot_plug_detection,
.is_connected = sii164IsConnected,
.check_interrupt = sii164CheckInterrupt,
.clear_interrupt = sii164ClearInterrupt,
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index d0b80b86a4d7..c8db6ceee9af 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -329,12 +329,12 @@ void sii164SelectHotPlugDetectionMode(enum sii164_hot_plug_mode hotPlugMode)
}
/*
- * sii164EnableHotPlugDetection
+ * sii164_enable_hot_plug_detection
* This function enables the Hot Plug detection.
*
- * enableHotPlug - Enable (=1) / disable (=0) Hot Plug detection
+ * enable_hot_plug - Enable (=1) / disable (=0) Hot Plug detection
*/
-void sii164EnableHotPlugDetection(unsigned char enableHotPlug)
+void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug)
{
unsigned char detectReg;
@@ -343,7 +343,7 @@ void sii164EnableHotPlugDetection(unsigned char enableHotPlug)
/* Depending on each DVI controller, need to enable the hot plug based
* on each individual chip design.
*/
- if (enableHotPlug != 0)
+ if (enable_hot_plug != 0)
sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_USE_MDI);
else
sii164SelectHotPlugDetectionMode(SII164_HOTPLUG_DISABLE);
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index c15cd6a5d53b..9e289bf4a78e 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -34,7 +34,7 @@ unsigned short sii164_get_device_id(void);
void sii164_reset_chip(void);
char *sii164_get_chip_string(void);
void sii164_set_power(unsigned char powerUp);
-void sii164EnableHotPlugDetection(unsigned char enableHotPlug);
+void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug);
unsigned char sii164IsConnected(void);
unsigned char sii164CheckInterrupt(void);
void sii164ClearInterrupt(void);
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 6/8] staging: sm750fb: change sii164IsConnected to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
` (4 preceding siblings ...)
2025-04-08 10:20 ` [PATCH v2 5/8] staging: sm750fb: change sii164EnableHotPlugDetection " Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 7/8] staging: sm750fb: change sii164CheckInterrupt " Richard Akintola
2025-04-08 10:20 ` [PATCH v2 8/8] staging: sm750fb: change sii164ClearInterrupt " Richard Akintola
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164IsConnected to sii164_is_connected
to conform to kernel code styles as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164IsConnected>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 1ce44c50617a..ac1aab77da28 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -22,7 +22,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.get_chip_string = sii164_get_chip_string,
.set_power = sii164_set_power,
.enable_hot_plug_detection = sii164_enable_hot_plug_detection,
- .is_connected = sii164IsConnected,
+ .is_connected = sii164_is_connected,
.check_interrupt = sii164CheckInterrupt,
.clear_interrupt = sii164ClearInterrupt,
#endif
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index c8db6ceee9af..6ce15b7816d9 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -350,14 +350,14 @@ void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug)
}
/*
- * sii164IsConnected
+ * sii164_is_connected
* Check if the DVI Monitor is connected.
*
* Output:
* 0 - Not Connected
* 1 - Connected
*/
-unsigned char sii164IsConnected(void)
+unsigned char sii164_is_connected(void)
{
unsigned char hotPlugValue;
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 9e289bf4a78e..90b7ae823a10 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -35,7 +35,7 @@ void sii164_reset_chip(void);
char *sii164_get_chip_string(void);
void sii164_set_power(unsigned char powerUp);
void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug);
-unsigned char sii164IsConnected(void);
+unsigned char sii164_is_connected(void);
unsigned char sii164CheckInterrupt(void);
void sii164ClearInterrupt(void);
#endif
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 7/8] staging: sm750fb: change sii164CheckInterrupt to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
` (5 preceding siblings ...)
2025-04-08 10:20 ` [PATCH v2 6/8] staging: sm750fb: change sii164IsConnected " Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
2025-04-08 10:20 ` [PATCH v2 8/8] staging: sm750fb: change sii164ClearInterrupt " Richard Akintola
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164CheckInterrupt to
sii164_check_interrupt in order to conform to kernel code styles
as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164CheckInterrupt>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index ac1aab77da28..1def02be4cce 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -23,7 +23,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.set_power = sii164_set_power,
.enable_hot_plug_detection = sii164_enable_hot_plug_detection,
.is_connected = sii164_is_connected,
- .check_interrupt = sii164CheckInterrupt,
+ .check_interrupt = sii164_check_interrupt,
.clear_interrupt = sii164ClearInterrupt,
#endif
},
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index 6ce15b7816d9..aebde3d8b903 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -370,14 +370,14 @@ unsigned char sii164_is_connected(void)
}
/*
- * sii164CheckInterrupt
+ * sii164_check_interrupt
* Checks if interrupt has occurred.
*
* Output:
* 0 - No interrupt
* 1 - Interrupt occurs
*/
-unsigned char sii164CheckInterrupt(void)
+unsigned char sii164_check_interrupt(void)
{
unsigned char detectReg;
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index 90b7ae823a10..aa3f34c13979 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -36,7 +36,7 @@ char *sii164_get_chip_string(void);
void sii164_set_power(unsigned char powerUp);
void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug);
unsigned char sii164_is_connected(void);
-unsigned char sii164CheckInterrupt(void);
+unsigned char sii164_check_interrupt(void);
void sii164ClearInterrupt(void);
#endif
/*
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH v2 8/8] staging: sm750fb: change sii164ClearInterrupt to snake_case
2025-04-08 10:20 [PATCH v2 0/8] staging: sm750fb: change function naming style Richard Akintola
` (6 preceding siblings ...)
2025-04-08 10:20 ` [PATCH v2 7/8] staging: sm750fb: change sii164CheckInterrupt " Richard Akintola
@ 2025-04-08 10:20 ` Richard Akintola
7 siblings, 0 replies; 9+ messages in thread
From: Richard Akintola @ 2025-04-08 10:20 UTC (permalink / raw)
To: outreachy
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Richard Akintola
Change camelCase function name sii164ClearInterrupt to
sii164_clear_interrupt in order to conform to kernel code styles
as reported by checkpatch.pl
CHECK: Avoid camelCase: <sii164ClearInterrupt>
Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
---
drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_dvi.c b/drivers/staging/sm750fb/ddk750_dvi.c
index 1def02be4cce..6fef1ab484c1 100644
--- a/drivers/staging/sm750fb/ddk750_dvi.c
+++ b/drivers/staging/sm750fb/ddk750_dvi.c
@@ -24,7 +24,7 @@ static struct dvi_ctrl_device dcft_supported_dvi_controller[] = {
.enable_hot_plug_detection = sii164_enable_hot_plug_detection,
.is_connected = sii164_is_connected,
.check_interrupt = sii164_check_interrupt,
- .clear_interrupt = sii164ClearInterrupt,
+ .clear_interrupt = sii164_clear_interrupt,
#endif
},
#endif
diff --git a/drivers/staging/sm750fb/ddk750_sii164.c b/drivers/staging/sm750fb/ddk750_sii164.c
index aebde3d8b903..fc725a9952d4 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.c
+++ b/drivers/staging/sm750fb/ddk750_sii164.c
@@ -390,10 +390,10 @@ unsigned char sii164_check_interrupt(void)
}
/*
- * sii164ClearInterrupt
+ * sii164_clear_interrupt
* Clear the hot plug interrupt.
*/
-void sii164ClearInterrupt(void)
+void sii164_clear_interrupt(void)
{
unsigned char detectReg;
diff --git a/drivers/staging/sm750fb/ddk750_sii164.h b/drivers/staging/sm750fb/ddk750_sii164.h
index aa3f34c13979..ebc173658f0e 100644
--- a/drivers/staging/sm750fb/ddk750_sii164.h
+++ b/drivers/staging/sm750fb/ddk750_sii164.h
@@ -37,7 +37,7 @@ void sii164_set_power(unsigned char powerUp);
void sii164_enable_hot_plug_detection(unsigned char enable_hot_plug);
unsigned char sii164_is_connected(void);
unsigned char sii164_check_interrupt(void);
-void sii164ClearInterrupt(void);
+void sii164_clear_interrupt(void);
#endif
/*
* below register definition is used for
--
2.39.5
^ permalink raw reply related [flat|nested] 9+ messages in thread