From: Akira Yokosawa <akiyks@gmail.com>
To: paulmck@linux.vnet.ibm.com
Cc: perfbook@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH] advsync: Fix store-buffering sequence table
Date: Thu, 6 Jul 2017 07:40:45 +0900 [thread overview]
Message-ID: <030d74ba-e816-cde6-5c31-a0cf25a3b320@gmail.com> (raw)
In-Reply-To: <20170705223218.GH2393@linux.vnet.ibm.com>
On 2017/07/06 7:32, Paul E. McKenney wrote:
> On Thu, Jul 06, 2017 at 07:15:24AM +0900, Akira Yokosawa wrote:
>> On 2017/07/05 10:32:49 -0700, Paul E. McKenney wrote:
>
> [ . . . ]
>
>>>>> So I cannot go with "volatile", but let's see if I can do something
>>>>> better than the gcc intrinsics.
>>>>
>>>> And if the litmus7 guys don't have anything for me, I can always write a
>>>> script to do the conversions. So either way, we will have kernel-style
>>>> notation at some point. ;-)
>>>
>>> And it turns out that the contents of a second "{}" in a litmus7 test
>>> is pulled directly into the output code, so an easy change. ;-)
>>
>> Good news!
>>
>> So __atomic_thread_fence() will also be replaced with smp_mb() in
>> the litmus tests? That will reduce the width of the tables and eliminate
>> the need for the hspece adjustments in one-column layout.
>
> Oops, I forgot to push! Done now.
>
> And yes, there is now smp_mb() in the litmus tests and the tables.
I'll take a look later.
As I mentioned earlier, __atomic_load_n() and __atomic_store_n() seem
to have fairly large overheads (on x86). You might want to see the changes
in the resulting statistics and reflect them in the text.
Thanks, Akira
>
> Thanx, Paul
>
>
next prev parent reply other threads:[~2017-07-05 22:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:23 [PATCH] advsync: Fix store-buffering sequence table Akira Yokosawa
2017-07-04 22:21 ` Paul E. McKenney
2017-07-05 14:22 ` Akira Yokosawa
2017-07-05 15:40 ` Paul E. McKenney
2017-07-05 15:50 ` Paul E. McKenney
2017-07-05 17:32 ` Paul E. McKenney
2017-07-05 22:15 ` Akira Yokosawa
2017-07-05 22:32 ` Paul E. McKenney
2017-07-05 22:40 ` Akira Yokosawa [this message]
2017-07-06 0:46 ` Paul E. McKenney
2017-07-06 1:07 ` Akira Yokosawa
2017-07-06 12:09 ` Akira Yokosawa
2017-07-06 18:20 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=030d74ba-e816-cde6-5c31-a0cf25a3b320@gmail.com \
--to=akiyks@gmail.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox