Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH v2 0/3] qqz and runlatex improvements
Date: Sat, 23 Apr 2016 12:20:30 -0700	[thread overview]
Message-ID: <20160423192029.GP3756@linux.vnet.ibm.com> (raw)
In-Reply-To: <571B5FBE.6030005@gmail.com>

On Sat, Apr 23, 2016 at 08:42:54PM +0900, Akira Yokosawa wrote:
> >From 0a9063f5bfc9a984b505fefe54d347f39e099f58 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiysw@gmail.com>
> Date: Sat, 23 Apr 2016 20:37:29 +0900
> Subject: [PATCH v2 0/3] qqz and runlatex improvements
> 
> Hi,
> 
> There have been two issues that bother me a little since I began to
> build perfbook.pdf myself.
> One is the cross-link references of quick quizzes that land on random
> nearby places in the PDF.
> The other is the premature termination of make with warning messages
> displayed.
> I think I have managed to fix both issues.
> 
> However, .sty file modification may introduce regressions and
> should be fully tested before being pushed out. Can anybody on the
> list test it and give feedback?
> 
> Thanks.
> 
> Changes since v1:
> Refactored runlatex.sh into 3 parts and improved the build behavior
> in response to the feedbacks from Paul[1].
> As the result of the change, *.bbl files are not necessary any more,
> so a patch to remove them is added.
> 
> [1] http://www.spinics.net/lists/perfbook/msg00160.html

I played around with it a bit, and it is very nice, a definite improvement
over my original!!!  Thank you!

Just a couple of very small things left:

1.	Because perfbook currently has a fairly low change rate and
	a mostly linear history, please feel free to put something
	like "previous commit" or "next commit" in place of your
	X-ed-out SHA-1 commit IDs.

	If you really want to include the SHA-1 numbers for the
	backwards references, that is fine, just set them up and
	send me a pull request.  (When I "git am" your email, I will
	get different SHA-1 commit IDs than you got, but "git pull"
	preserves the IDs.)

	Your choice!

2.	The second patch gets a trailing-whitespace error.  Could you
	please fix that?

							Thanx, Paul

> Akira Yokosawa (3):
>   qqz: Improve accuracy of cross-links
>   Improve behavior of build scripts
>   Remove *.bbl from repository
> 
>  .gitignore                 |    2 +-
>  Makefile                   |   55 +-
>  perfbook-1c.bbl            | 2103 -------------------------------------------
>  perfbook-hb.bbl            | 1949 ----------------------------------------
>  perfbook.bbl               | 2146 --------------------------------------------
>  qqz.sty                    |   14 +-
>  utilities/runfirstlatex.sh |   46 +
>  utilities/runlatex.sh      |   85 +-
>  8 files changed, 168 insertions(+), 6232 deletions(-)
>  delete mode 100644 perfbook-1c.bbl
>  delete mode 100644 perfbook-hb.bbl
>  delete mode 100644 perfbook.bbl
>  create mode 100644 utilities/runfirstlatex.sh
> 
> -- 
> 1.9.1
> 


      parent reply	other threads:[~2016-04-23 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-23 11:42 [PATCH v2 0/3] qqz and runlatex improvements Akira Yokosawa
2016-04-23 11:44 ` [PATCH v2 1/3] qqz: Improve accuracy of cross-links Akira Yokosawa
2016-04-23 11:46 ` [PATCH v2 2/3] Improve behavior of build scripts Akira Yokosawa
2016-04-23 11:48 ` [PATCH v2 3/3] Remove *.bbl from repository Akira Yokosawa
2016-04-23 14:56 ` [PATCH v2 0/3] qqz and runlatex improvements Akira Yokosawa
2016-04-23 19:24   ` Paul E. McKenney
2016-04-23 19:20 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160423192029.GP3756@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox