Re: [PATCH] Makefile: Possible fix for warning of duplicated target

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Fri, Jun 10, 2016 at 11:46:27PM +0900, Akira Yokosawa wrote:
> >From ad4c29bc05026135cb56f66e79585b6788c2a3aa Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Fri, 10 Jun 2016 23:26:01 +0900
> Subject: [PATCH] Makefile: Possible fix for warning of duplicated target
> 
> This commit fixes use of flavors of variables in Makefile.
> We should use "simply expanded variables" for variables
> which are referenced in definitions of other variables.
> 
> Reported-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>

This gets rid of the warnings, thank you!  Queued and pushed.

							Thanx, Paul

> ---
>  Makefile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 446c5f8..b508e61 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -5,29 +5,29 @@ LATEXSOURCES = \
>  	*/*.tex \
>  	*/*/*.tex
> 
> -EPSSOURCES_FROM_TEX = \
> +EPSSOURCES_FROM_TEX := \
>  	SMPdesign/DiningPhilosopher5.eps \
>  	SMPdesign/DiningPhilosopher5TB.eps \
>  	SMPdesign/DiningPhilosopher4part-b.eps \
>  	SMPdesign/DiningPhilosopher5PEM.eps
> 
> -DOTSOURCES = $(wildcard */*.dot)
> +DOTSOURCES := $(wildcard */*.dot)
> 
>  EPSSOURCES_FROM_DOT := $(DOTSOURCES:%.dot=%.eps)
> 
> -EPSSOURCES_DUP = \
> +EPSSOURCES_DUP := \
>  	$(wildcard */*.eps) \
>  	$(wildcard */*/*.eps) \
>  	$(EPSSOURCES_FROM_TEX) \
>  	$(EPSSOURCES_FROM_DOT)
> 
> -EPSSOURCES = $(sort $(EPSSOURCES_DUP))
> +EPSSOURCES := $(sort $(EPSSOURCES_DUP))
> 
>  PDFTARGETS_OF_EPS := $(EPSSOURCES:%.eps=%.pdf)
> 
>  BIBSOURCES = bib/*.bib
> 
> -SVGSOURCES = $(wildcard */*.svg)
> +SVGSOURCES := $(wildcard */*.svg)
> 
>  PDFTARGETS_OF_SVG := $(SVGSOURCES:%.svg=%.pdf)
> 
> -- 
> 1.9.1
> 
>