Re: [PATCH v2] treewide: Add \noindent where necessary

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Tue, Sep 06, 2016 at 10:18:53PM +0900, Akira Yokosawa wrote:
> On 2016/09/06 21:01, Paul E. McKenney wrote:
> > On Tue, Sep 06, 2016 at 08:17:29PM +0900, Akira Yokosawa wrote:
> >> On 2016/09/05 23:47:56 +0900, Akira Yokosawa wrote:
> >>> >From 3590a93264e8497f5464397de1644076cd28f467 Mon Sep 17 00:00:00 2001
> >>> From: Akira Yokosawa <akiyks@gmail.com>
> >>> Date: Sun, 4 Sep 2016 08:01:50 +0900
> >>> Subject: [PATCH v2] treewide: Add \noindent where necessary
> >>>
> >>> When there is some environment definition just after a section
> >>> heading, the implicit non-indentation of first paragraph is lost.
> >>>
> >>> This seems inconsistent.
> >>>
> >>> This commit adds "\noindent"s just before such first paragraphs
> >>> to recover the non-indentation.
> >>>
> >>> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> >>
> >> Hi Paul,
> >>
> >> I'd like to retract this patch.
> >> I suppose you don't like explicit \noindent in the text either.
> >>
> >> I prefer fixing the position of first paragraphs in the latex source.
> >> That might cause the variation in position of floating figures, but
> >> should be acceptable.
> >>
> >> What do you think?
> > 
> > My first thought was "just make the environment do it", thinking that
> > this was of of the origpub macros.
> > 
> > Another thought is to forbid use of floating figures immediately after
> > section headers.  That would be a bit of an ugly change, but much easier
> > to maintain against changing LaTeX versions.
> > 
> > I am mostly working on code, so now is a good time for invasive changes
> > like this, but I do want to avoid the current change just resulting in
> > the need for many future changes.  Especially given differences between
> > different formatting options.  ;-)
> 
> Indeed.
> 
> About the origpub macro involved in one of the hunks, if you replace it
> with standard \label{}, the paragraph under the figure is still indented.
> 
> Regarding the figure itself as a paragraph, the paragraph under it is
> the second one and indentation should be expected.
> 
> Addition of \noindent there was unnecessary from the beginning.
> 
> The other hunks are all related to the "verbbox" environment, which I
> introduced.  That means I'm shooting myself in the foot... 
> 
> So moving floating figures seems to be necessary only when they are
> related to "verbbox".
> 
> It would be even better if we can fix the side-effect of "verbbox"
> environment. Let me seek this approach first.

Sounds good to me!

							Thanx, Paul