Re: [PATCH v2] autodate.sh: Use printf command instead of echo

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Sat, Jan 21, 2017 at 12:01:59AM +0900, Akira Yokosawa wrote:
> On 2017/01/19 20:16, Akira Yokosawa wrote:
> >>From b981648ff25387ecea68b55350671c55ad894884 Mon Sep 17 00:00:00 2001
> > From: Akira Yokosawa <akiyks@gmail.com>
> > Date: Tue, 17 Jan 2017 20:04:54 +0900
> > Subject: [PATCH v2] autodate.sh: Use printf command instead of echo
> > 
> > Using "echo" command to generate output containing "\" characters
> > caused a build error depending on the variant of "sh".
> > For portability, we should use "printf" via "env" command.
> > 
> > Fixes: 878bf8160a5c ("Make date of git commit be reflected automatically")
> > Reported-by: Trevor Woerner <twoerner@gmail.com>
> > Tested-by: Trevor Woerner <twoerner@gmail.com>
> > Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> > ---
> > v2: Changes in commit log
> >       o Tested-by from Trevor
> >       o Title of fixed commit
> 
> Well, seems like I should have put the "Tested-by:" from Trevor
> below my "Signed-off-by:" to respect the chain of event.
> If it is not too late, can you reorder them for me?

You got lucky, internet-access troubles.  ;-)

Queued and pushed with the Tested-by and Signed-off-by reversed.

							Thanx, Paul

>                                       Thanks, Akira                     
> 
> > 
> >  utilities/autodate.sh | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/utilities/autodate.sh b/utilities/autodate.sh
> > index 6df8f99..a56bc70 100644
> > --- a/utilities/autodate.sh
> > +++ b/utilities/autodate.sh
> > @@ -35,7 +35,7 @@ else
> >  	gitstatus=`git status --porcelain | wc -l`
> >  	if [ $gitstatus != "0" ]
> >  	then
> > -		modified=" (m)"
> > +		modified="(m)"
> >  	else
> >  		modified=""
> >  	fi
> > @@ -44,5 +44,5 @@ month=`date --date="$date_str" +%B`
> >  year=`date --date="$date_str" +%Y`
> >  day=`date --date="$date_str" +%e`
> >  
> > -echo "\\date{$month $day, $year$modified}"
> > -echo "\\\newcommand{\\\commityear}{$year}"
> > +env printf "\\date{%s %s, %s %s}\n" $month $day $year $modified
> > +env printf "\\\newcommand{\\\commityear}{%s}\n" $year
> > 
>