From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] advsync: Fix control-dependency no-transitivity example
Date: Wed, 19 Jul 2017 10:30:26 -0700 [thread overview]
Message-ID: <20170719173026.GF3730@linux.vnet.ibm.com> (raw)
In-Reply-To: <165340ca-3acd-a8be-43ad-ccf64582aa21@gmail.com>
On Fri, Jul 14, 2017 at 11:34:45PM +0900, Akira Yokosawa wrote:
> >From 8740c546fbb6988c2fcf4a88c4314df972d0b9b7 Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Fri, 14 Jul 2017 22:48:37 +0900
> Subject: [PATCH] advsync: Fix control-dependency no-transitivity example
>
> The corresponding assert condition in memory-barriers.txt was
> fixed in commit 5646f7acc95f ("memory-barriers: Fix control-
> ordering no-transitivity example") of Linux kernel repository.
> Somehow it was imported to perfbook in a wrong form and has
> survived since.
>
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
And I did take this, thank you very much, and please accept my apologies
for the delay.
If I understand correctly, I should leave your second patch alone.
If I am confused, please let me know!
Thanx, Paul
> ---
> advsync/memorybarriers.tex | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
> index c9c975c..25a90b2 100644
> --- a/advsync/memorybarriers.tex
> +++ b/advsync/memorybarriers.tex
> @@ -3036,9 +3036,9 @@ not), then adding the following CPU would guarantee a related assertion:
> \begin{tabular}{l}
> \nf{CPU 2} \\
> \hline
> - \tco{WRITE_ONCE(y, 1);} \\
> + \tco{WRITE_ONCE(x, 2);} \\
> \multicolumn{1}{l}{~} \\
> - \multicolumn{1}{l}{\tco{assert(!(r1 == 1 && r2 == 1 && x == 1));}} \\
> + \multicolumn{1}{l}{\tco{assert(!(r1 == 2 && r2 == 1 && x == 2));}} \\
> \end{tabular}
> \end{minipage}
> \vspace{5pt}
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-07-19 17:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 14:34 [PATCH] advsync: Fix control-dependency no-transitivity example Akira Yokosawa
2017-07-16 14:27 ` [PATCH] advsync: Fix two-CPU control-dependency example Akira Yokosawa
2017-07-16 23:40 ` Paul E. McKenney
2017-07-17 0:45 ` Akira Yokosawa
2017-07-19 17:38 ` Paul E. McKenney
2017-07-19 17:30 ` Paul E. McKenney [this message]
2017-07-19 21:53 ` [PATCH] advsync: Fix control-dependency no-transitivity example Akira Yokosawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170719173026.GF3730@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akiyks@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox