Re: [PATCH 03/10] Localize floatrow.sty

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Mon, Jul 31, 2017 at 02:01:55PM +0900, Akira Yokosawa wrote:
> 2017/07/31 13:05、Akira Yokosawa <akiyks@gmail.com> のメッセージ:
> 
> > 
> > 
> > 
> > 
> > 2017/07/31 12:26、Paul E. McKenney <paulmck@linux.vnet.ibm.com> のメッセージ:
> > 
> >> On Fri, Jul 28, 2017 at 06:58:07PM +0900, Akira Yokosawa wrote:
> >>>> From 53ff86011be07a62dba37a5bef56f04f25531dd1 Mon Sep 17 00:00:00 2001
> >>> From: Akira Yokosawa <akiyks@gmail.com>
> >>> Date: Thu, 20 Jul 2017 23:34:58 +0900
> >>> Subject: [PATCH 03/10] Localize floatrow.sty
> >>> 
> >>> The "floatrow" package conflicts with two-column layout.
> >>> A possible workaround was posted at [1] and it seems to work
> >>> in perfbook. Before the change, import the style file as of v0.3b
> >>> with trailing white spaces removed.
> >>> 
> >>> [1] https://tex.stackexchange.com/questions/133127/
> >> 
> >> If I understand the license correctly, we have to use a different name
> >> due to having modified the file.  
> > 
> > Yes.
> > I did the rename in the next commit. By splitting them,
> > it would be easier to see the workaround.
> 
> Ah, now I see your point.
> This patch should have used the renamed file name.
> Then the following diff would have been much smaller.
> 
> I'll respin later.

Very good, thank you!

							Thanx, Paul

> Thanks, Akira 
> (from mobile, might be QP encoded)
> 
> > 
> > Or, do we need to keep the trailing blanks at this point?
> > 
> >> Or has this change (commenting out
> >> \textwidth\columnwidth) been applied upstream?
> > 
> > No, the workaround looks like only a hint.
> > Again, two-column layout tend to have little attention.
> > 
> >> Or does changing the
> >> name mean that the fix is ineffective?
> > 
> > It is effective for perfbook AFAICS.
> > 
> > Thanks, Akira 
> > (from mobile, might be QP encoded)
> >> 
> >> (I applied the first two, thank you!)
> >> 
> >>                           Thanx, Paul
> 
> [...]--
> To unsubscribe from this list: send the line "unsubscribe perfbook" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>