Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH] advsync: Fix typo
Date: Thu, 24 Aug 2017 09:50:35 -0700	[thread overview]
Message-ID: <20170824165035.GR11320@linux.vnet.ibm.com> (raw)
In-Reply-To: <80b3d435-7485-0e5c-ba2d-c2d8c463f4a7@gmail.com>

On Thu, Aug 24, 2017 at 11:49:54PM +0900, Akira Yokosawa wrote:
> >From 8d70beda36d683ee6869581155db91153b68338c Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Thu, 24 Aug 2017 23:30:50 +0900
> Subject: [PATCH] advsync: Fix typo
> 
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> ---
> Hi Paul,
> 
> This patch fixes a few typos after your self-review.
> I'm not sure if the 1st hunk of "stop -> step" is necessary.
> If "stop" was your intended word choice, please omit it.

I took your second and third changes, and added words in a separate commit
to (hopefully) clarify "stop" as in "stop along a journey".  Please let
me know what you think!

							Thanx, Paul

>      Thanks, Akira
> --
>  advsync/memorybarriers.tex | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/advsync/memorybarriers.tex b/advsync/memorybarriers.tex
> index dd8acf8..db6d486 100644
> --- a/advsync/memorybarriers.tex
> +++ b/advsync/memorybarriers.tex
> @@ -341,7 +341,7 @@ exists (1:r2=0 /\ 0:r2=0)
>  However, if you need to implement the synchronization primitives
>  themselves, or if you are simply interested in understanding how memory
>  ordering and memory barriers work, read on!
> -The first stop is
> +The first step is
>  Listing~\ref{lst:advsync:Memory Ordering: Store-Buffering Litmus Test}
>  (\path{C-SB+o-mb-o+o-mb-o.litmus}),
>  which the \co{smp_mb()} Linux-kernel full memory barrier placed between
> @@ -613,7 +613,7 @@ Section~\ref{sec:advsync:Memory Ordering and Memory Barriers}
>  showed that even relatively strongly ordered systems like x86
>  can reorder prior stores with later loads, at least when the
>  store and load are to different variables.
> -This section buids on that result, looking at the other combinations of
> +This section builds on that result, looking at the other combinations of
>  loads and stores.
> 
>  % @@@ Rationale for further reordering.
> @@ -665,7 +665,7 @@ but no ordering is specified for the reads.
>  Relatively strongly ordered architectures, such as x86, do enforce ordering.
>  However, weakly ordered architectures often do
>  not~\cite{JadeAlglave2011ppcmem}.
> -Therefore, the \co{exists} clause on line~25 of the figure \emph{can}
> +Therefore, the \co{exists} clause on line~25 of the listing \emph{can}
>  trigger.
> 
>  \begin{listing}[tbp]
> -- 
> 2.7.4
> 


  reply	other threads:[~2017-08-24 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-24 14:49 [PATCH] advsync: Fix typo Akira Yokosawa
2017-08-24 16:50 ` Paul E. McKenney [this message]
2017-08-24 22:17   ` Akira Yokosawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170824165035.GR11320@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox