From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [GIT PULL v5] Trial of labeling lines in code snippets
Date: Sun, 5 Aug 2018 09:35:08 -0700 [thread overview]
Message-ID: <20180805163508.GI24813@linux.vnet.ibm.com> (raw)
In-Reply-To: <65eb47fb-678b-b8a1-9c5b-483e82b6516a@gmail.com>
On Sun, Aug 05, 2018 at 09:06:27AM +0900, Akira Yokosawa wrote:
> Hi Paul,
>
> This is hopefully the final version of this trial branch.
>
> Changes since v4:
>
> o Instead of generating CodeSamples/snippets.mk and calling it from
> main Makefile, generate CodeSamples/snippets.d which contains
> only dependencies and include it in the Makefile.
>
> This change can fix the error you encountered in the previous version.
> I'm just hoping...
Hmmmm...
$ make
sh ./utilities/gen_snippet_d.sh
CodeSamples/toolsoftrade/pcreate.c --> CodeSamples/toolsoftrade/pcreate@mythread.fcv
But "make 2c" works. This might be because I don't have the
PERFBOOK_DEFAULT environment variable set? Except that the Makefile code
looks like this would have the default "make all" have the same effect as
"make 2c". Color me confused.
Anyway, yes, when I do "make 2c" it correctly reacts to moving labels
around in CodeSamples/toolsoftrade/forkjoinvar.c, so that is good!
Here is the output of "make -v", in case that matters:
GNU Make 3.81
Copyright (C) 2006 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
This program built for x86_64-pc-linux-gnu
Thanx, Paul
> Thanks, Akira
>
> ---
> The following changes since commit 3b62f67a76e15f8d8f8190a4252362d4ac0cdf23:
>
> Regenerating the atomic counter graph on a more modern CPU (2018-07-23 13:47:51 -0700)
>
> are available in the git repository at:
>
> https://github.com/akiyks/perfbook.git trial-fancyvrb-20180804b
>
> for you to fetch changes up to d9a36224084b2e4ba55797eff0c37de528b59d6b:
>
> Add dependencies of perfbook_flat.tex to CodeSamples/.../*.fcv files (2018-08-05 08:44:02 +0900)
>
> ----------------------------------------------------------------
> Akira Yokosawa (12):
> toolsoftrade: Add labels in code samples as comments
> Add script to extract code snippet from code sample
> toolsoftrade: Reference line in code snippets by label
> Update hyphen2endash
> Add *.fcv to .gitignore
> Automate sub makefile update
> Specify lmtt font for VerbatimM env
> toolsoftrade: Use \lnlbl in inline code snippet
> Add 'linelabel' and 'lineref' environment
> Catch failure in genaration of CodeSamples/snippets.mk
> Add dependencis to scripts for extracting code snippets
> Add dependencies of perfbook_flat.tex to CodeSamples/.../*.fcv files
>
> .gitignore | 2 +
> CodeSamples/api-pthreads/api-pthreads.h | 18 +--
> CodeSamples/toolsoftrade/forkjoinvar.c | 12 +-
> CodeSamples/toolsoftrade/pcreate.c | 7 +-
> Makefile | 25 +++-
> perfbook.tex | 21 ++++
> toolsoftrade/toolsoftrade.tex | 211 +++++++++++---------------------
> utilities/fcvextract.pl | 168 +++++++++++++++++++++++++
> utilities/gen_snippet_d.pl | 65 ++++++++++
> utilities/gen_snippet_d.sh | 8 ++
> utilities/hyphen2endash.sh | 3 +
> 11 files changed, 382 insertions(+), 158 deletions(-)
> create mode 100755 utilities/fcvextract.pl
> create mode 100755 utilities/gen_snippet_d.pl
> create mode 100644 utilities/gen_snippet_d.sh
>
next prev parent reply other threads:[~2018-08-05 18:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 0:19 [NOT YET PULL] Trial of labeling lines in code snippets Akira Yokosawa
2018-07-21 16:51 ` Paul E. McKenney
2018-07-22 15:43 ` Akira Yokosawa
2018-07-22 22:49 ` Paul E. McKenney
2018-07-23 15:09 ` Akira Yokosawa
2018-07-23 15:12 ` Akira Yokosawa
2018-07-23 21:03 ` Paul E. McKenney
2018-07-30 16:04 ` [NOT YET PULL v2] " Akira Yokosawa
2018-07-31 15:10 ` Paul E. McKenney
2018-08-01 15:24 ` Akira Yokosawa
2018-08-01 15:59 ` Paul E. McKenney
2018-08-01 22:14 ` Akira Yokosawa
2018-08-02 0:22 ` Paul E. McKenney
2018-08-02 22:34 ` [GIT PULL v3] " Akira Yokosawa
2018-08-03 14:35 ` Paul E. McKenney
2018-08-03 15:02 ` Akira Yokosawa
2018-08-03 15:49 ` Akira Yokosawa
2018-08-03 16:45 ` Paul E. McKenney
2018-08-03 23:12 ` Akira Yokosawa
2018-08-03 23:43 ` Paul E. McKenney
2018-08-04 0:00 ` Akira Yokosawa
2018-08-04 11:57 ` [GIT PULL v4] " Akira Yokosawa
2018-08-04 15:15 ` Akira Yokosawa
2018-08-05 0:06 ` [GIT PULL v5] " Akira Yokosawa
2018-08-05 16:35 ` Paul E. McKenney [this message]
2018-08-05 16:54 ` Paul E. McKenney
2018-08-05 21:58 ` Akira Yokosawa
2018-08-05 22:47 ` Paul E. McKenney
2018-08-05 23:26 ` Akira Yokosawa
2018-08-05 23:40 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180805163508.GI24813@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akiyks@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox