Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH 0/5] count: Employ new code-snippet scheme (cont.)
Date: Mon, 8 Oct 2018 20:54:27 -0700	[thread overview]
Message-ID: <20181009035427.GH2674@linux.ibm.com> (raw)
In-Reply-To: <9c31cb06-b79f-3b9c-e86a-68fb3840f688@gmail.com>

On Mon, Oct 08, 2018 at 10:40:51AM +0900, Akira Yokosawa wrote:
> Hi Paul,
> 
> This is the continuation of changes to snippets in the "count"
> chapter.
> 
> To help your review of the changes regarding READ_ONCE()/WRITE_ONCE(),
> I split the patches to the ones just applying the scheme and
> the ones modifying READ_ONCE()/WRITE_ONCE().
> 
> Note on patch #3: It fixes the segfault observed in count_tstat.
> However, I'm not sure if you want to take it or not. The fail can
> be thought of as a Quick Quiz within the Answer to the Quick Quiz.
> So keeping it as is would also be reasonable.
> 
>         Thanks, Akira

They look good at first glance, so I have queued and pushed them.
Thank you very much!

							Thanx, Paul

> --
> Akira Yokosawa (5):
>   count: Employ new scheme for snippet of count_end and count_tstat
>   count: Fix uses of READ/WRITE_ONCE()s in count_end and count_tstat
>   count: Tweak counttorture.h to avoid segfault
>   count: Employ new scheme for snippet of count_lim
>   count: Fix uses of READ/WRITE_ONCE() in count_lim
> 
>  CodeSamples/count/count_end.c    |  53 ++---
>  CodeSamples/count/count_lim.c    | 147 +++++++------
>  CodeSamples/count/count_tstat.c  |  27 +--
>  CodeSamples/count/counttorture.h |  21 +-
>  count/count.tex                  | 437 +++++++++++++--------------------------
>  5 files changed, 287 insertions(+), 398 deletions(-)
> 
> -- 
> 2.7.4
> 


      parent reply	other threads:[~2018-10-09 11:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08  1:40 [PATCH 0/5] count: Employ new code-snippet scheme (cont.) Akira Yokosawa
2018-10-08  1:42 ` [PATCH 1/5] count: Employ new scheme for snippet of count_end and count_tstat Akira Yokosawa
2018-10-08  1:44 ` [PATCH 2/5] count: Fix uses of READ/WRITE_ONCE()s in " Akira Yokosawa
2018-10-08  1:46 ` [PATCH 3/5] count: Tweak counttorture.h to avoid segfault Akira Yokosawa
2018-10-08  1:47 ` [PATCH 4/5] count: Employ new scheme for snippet of count_lim Akira Yokosawa
2018-10-08  1:49 ` [PATCH 5/5] count: Fix uses of READ/WRITE_ONCE() in count_lim Akira Yokosawa
2018-10-08 14:02 ` [PATCH 6/5] count: Fix typo (\lnlbl{} -> \lnref{}) Akira Yokosawa
2018-10-09  3:54 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009035427.GH2674@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox