Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH 0/7] Further conversion of code snippets (howto, cpu, SMPdesign)
Date: Sun, 4 Nov 2018 12:30:42 -0800	[thread overview]
Message-ID: <20181104203042.GM4170@linux.ibm.com> (raw)
In-Reply-To: <fc130ee3-dbd0-b0d1-41a6-b49baa6b00e5@gmail.com>

On Sun, Nov 04, 2018 at 09:07:36AM +0900, Akira Yokosawa wrote:
> Hi Paul,
> 
> This is another set of patches converting code snippets to new scheme.
> Notes on the changes other than simple conversion follow.
> 
> Patch #2 contains somewhat ugly hack in lockhdeq.c to suppress
> "____cacheline_internodealigned_in_smp" in the resulting snippet.
> I'm afraid it could hurt your eyes.

;-)

> Patch #5 renames "percpu*" to "perthread*" to respect the names
> used in actual code.
> 
> Patch #6 includes substitution of ACCESS_ONCE -> READ_ONCE.
> 
> Patch #7 does the substitution under CodeSamples. It also adds
> a couple of function prototypes in maze.h.

The boxes for the inline code displays look good to me.  I have queued
these, and will push them once I get back on-grid.  Thank you!!!

							Thanx, Paul

>         Thanks, Akira
> --
> Akira Yokosawa (7):
>   howto, cpu: Employ new scheme for command/code snippets
>   SMPdesign: Employ new scheme for snippet of lockhdeq.c
>   SMPdesign: Employ new scheme for snippet of lockhdeq.c and locktdeq.c
>   SMPdesign: Employ new scheme for inline snippets
>   SMPdesign: Employ new scheme for snippets from smpalloc.c
>   SMPdesign/beyond: Employ new scheme for inline pseudocode snippets
>   CodeSamples/SMPdesign/maze: Substitute {READ/WRITE}_ONCE() for
>     ACCESS_ONCE()
> 
>  CodeSamples/SMPdesign/lockhdeq.c       |  53 ++--
>  CodeSamples/SMPdesign/locktdeq.c       |  70 ++---
>  CodeSamples/SMPdesign/maze/maze.h      |   6 +
>  CodeSamples/SMPdesign/maze/maze_fg.c   |  18 +-
>  CodeSamples/SMPdesign/maze/maze_part.c |  18 +-
>  CodeSamples/SMPdesign/smpalloc.c       |  57 ++--
>  SMPdesign/SMPdesign.tex                | 479 ++++++++++++++-------------------
>  SMPdesign/beyond.tex                   | 319 +++++++++++-----------
>  SMPdesign/partexercises.tex            | 263 ++++++------------
>  cpu/overview.tex                       |  15 +-
>  howto/howto.tex                        |  60 ++---
>  11 files changed, 605 insertions(+), 753 deletions(-)
> 
> -- 
> 2.7.4
> 


      parent reply	other threads:[~2018-11-05  8:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-04  0:07 [PATCH 0/7] Further conversion of code snippets (howto, cpu, SMPdesign) Akira Yokosawa
2018-11-04  0:08 ` [PATCH 1/7] howto, cpu: Employ new scheme for command/code snippets Akira Yokosawa
2018-11-04  0:09 ` [PATCH 2/7] SMPdesign: Employ new scheme for snippet of lockhdeq.c Akira Yokosawa
2018-11-04  0:11 ` [PATCH 3/7] SMPdesign: Employ new scheme for snippet of lockhdeq.c and locktdeq.c Akira Yokosawa
2018-11-04  0:11 ` [PATCH 4/7] SMPdesign: Employ new scheme for inline snippets Akira Yokosawa
2018-11-04  0:13 ` [PATCH 5/7] SMPdesign: Employ new scheme for snippets from smpalloc.c Akira Yokosawa
2018-11-04  0:13 ` [PATCH 6/7] SMPdesign/beyond: Employ new scheme for inline pseudocode snippets Akira Yokosawa
2018-11-04  0:15 ` [PATCH 7/7] CodeSamples/SMPdesign/maze: Substitute {READ/WRITE}_ONCE() for ACCESS_ONCE() Akira Yokosawa
2018-11-04 20:30 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181104203042.GM4170@linux.ibm.com \
    --to=paulmck@linux.ibm.com \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox