From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: Junchang Wang <junchangwang@gmail.com>, perfbook@vger.kernel.org
Subject: Re: [PATCH 0/2] Updates to Chapter memorder
Date: Mon, 5 Nov 2018 11:50:59 -0800 [thread overview]
Message-ID: <20181105195059.GB4170@linux.ibm.com> (raw)
In-Reply-To: <3efe6951-cade-b721-96e3-7d41e1c39734@gmail.com>
On Sun, Nov 04, 2018 at 09:04:28PM +0900, Akira Yokosawa wrote:
> On 2018/11/04 19:18:37 +0800, Junchang Wang wrote:
> > Hi Paul and Akira,
> >
> > I have read through the first half of Chapter memorder, and here is correction
> > for a few typos. Please take a look.
> >
> > For the first patch, the last clause I modified still looks confusion to me.
> > Currently the clause is "though only if both \co{r1} and \co{r3} both end up
> > containing the address of \co{x}"; however, my understanding is that prior load
> > or store would also be ordered before the store on line 16, __only if r1 ends up
> > containing the address of x__. That is, it is not necessary to involve r2/r3. Is
> > my understanding correct? Or did I miss anything about this in the book?
>
> Going back to commit 43236beadb19 ("memorder: Expand on cumulativity and
> {other,} multicopy atomicity"), this paragraph discussed Listing 14.17
> at the time (WWC Litmus Test With Release), which is a different litmus
> test than the current Listing 15.17 (WRC Litmus Test With Release).
> Still line 32 of then Listing 14.17 was an "exists" clause.
> No wonder you can't figure out what is discussed there.
>
> Paul, can you look into this?
Indeed, this was quite the mess! Hopefully now fixed. ;-)
Thanx, Paul
> Thanks, Akira
>
> >
> >
> > Thanks,
> > --Junchang
> >
> > Junchang Wang (2):
> > memorder: fix typo
> > memorybarriercum.svg: fix typo
> >
> > memorder/memorder.tex | 8 ++++----
> > memorder/memorybarriercum.svg | 2 +-
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
>
next prev parent reply other threads:[~2018-11-06 5:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 11:18 [PATCH 0/2] Updates to Chapter memorder Junchang Wang
2018-11-04 11:18 ` [PATCH 1/2] memorder: fix typo Junchang Wang
2018-11-05 19:45 ` Paul E. McKenney
2018-11-06 6:15 ` Junchang Wang
2018-11-04 11:18 ` [PATCH 2/2] memorybarriercum.svg: " Junchang Wang
2018-11-05 19:48 ` Paul E. McKenney
2018-11-04 12:04 ` [PATCH 0/2] Updates to Chapter memorder Akira Yokosawa
2018-11-05 19:50 ` Paul E. McKenney [this message]
2018-11-06 6:18 ` Junchang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181105195059.GB4170@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=akiyks@gmail.com \
--cc=junchangwang@gmail.com \
--cc=perfbook@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox