From: "Paul E. McKenney" <paulmck@linux.ibm.com>
To: Slavomir Kaslev <kaslevs@vmware.com>
Cc: perfbook@vger.kernel.org, rostedt@goodmis.org, slavomir.kaslev@gmail.com
Subject: Re: [PATCH] toolsoftrade: Fix code listing 4.22 in Chapter 4
Date: Tue, 19 Mar 2019 08:38:10 -0700 [thread overview]
Message-ID: <20190319153810.GV4102@linux.ibm.com> (raw)
In-Reply-To: <20190319145927.29610-1-kaslevs@vmware.com>
On Tue, Mar 19, 2019 at 04:59:27PM +0200, Slavomir Kaslev wrote:
> Code listing 4.22 is broken since the READ_ONCE() macro takes a rvalue and the
> expression parenthesis are unbalanced. This patch fixes it.
>
> Signed-off-by: Slavomir Kaslev <kaslevs@vmware.com>
Good eyes, thank you! Queued and pushed.
Thanx, Paul
> ---
> toolsoftrade/toolsoftrade.tex | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/toolsoftrade/toolsoftrade.tex b/toolsoftrade/toolsoftrade.tex
> index 41605a33..4e0764d0 100644
> --- a/toolsoftrade/toolsoftrade.tex
> +++ b/toolsoftrade/toolsoftrade.tex
> @@ -2111,7 +2111,7 @@ Listing~\ref{lst:toolsoftrade:Avoiding Danger, 2018 Style}.
> \begin{listing}[tbp]
> \begin{linelabel}[ln:toolsoftrade:Preventing Load Fusing]
> \begin{VerbatimL}[commandchars=\\\{\}]
> -while (!READ_ONCE((!need_to_stop))
> +while (!READ_ONCE(need_to_stop))
> do_something_quickly();
> \end{VerbatimL}
> \end{linelabel}
> --
> 2.19.1
>
prev parent reply other threads:[~2019-03-19 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 14:59 [PATCH] toolsoftrade: Fix code listing 4.22 in Chapter 4 Slavomir Kaslev
2019-03-19 15:33 ` Steven Rostedt
2019-03-19 15:40 ` Paul E. McKenney
2019-03-19 15:38 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319153810.GV4102@linux.ibm.com \
--to=paulmck@linux.ibm.com \
--cc=kaslevs@vmware.com \
--cc=perfbook@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=slavomir.kaslev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox