Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: Balbir Singh <bsingharora@gmail.com>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>, perfbook@vger.kernel.org
Subject: Re: [RFC PATCH] perfbook/papersize: ebook reader size support
Date: Wed, 24 Mar 2021 18:27:27 +1100	[thread overview]
Message-ID: <20210324072727.GL77072@balbir-desktop> (raw)
In-Reply-To: <4b4a3289-9bd3-7f54-8d5b-6722d4d05e2b@gmail.com>

On Wed, Mar 24, 2021 at 11:35:04AM +0900, Akira Yokosawa wrote:
> On Wed, 24 Mar 2021 12:15:29 +1100, Balbir Singh wrote:
> > On Tue, Mar 23, 2021 at 10:39:50PM +0900, Akira Yokosawa wrote:
> >> Hi Balbir,
> >>
> >> I am surprised to see perfbook's LaTeX codebase works fairly well
> >> in the ebook paper size.
> >>
> > 
> > It does and it makes it easier on the eyes. My suggestion is to
> > try the patch and then see for yourself, it'll help with the
> > improvements you suggest below
> >  
> >> Impressive, indeed!
> >>
> > 
> > Yep, the magic is done by LaTeX :)
> > 
> >> A few inline comments:
> >>
> >> On Tue, 23 Mar 2021 20:38:22 +1100, Balbir Singh wrote:
> >>> On Mon, Mar 22, 2021 at 10:23:54PM -0700, Paul E. McKenney wrote:
> >>>> On Tue, Mar 23, 2021 at 12:01:53PM +1100, Balbir Singh wrote:
> >>> ...
> >>>> Very good!
> >>>>
> >>>> But would it be possible to create a separate build target for this
> >>>> combination?  Just in case others are using 1c for normal-sized paper?
> >>>>
> >>>
> >>> Add support for ebooksize, which is roughly the size of
> >>> a kindle (4.5in, 6.3in) with margin size of 0.2in. The
> >>> recommended changes were taken from stackexchange with
> >>> links in the code. Not all tables take nicely to the
> >>> new size and warnings are produced, these warnings are about
> >>> about overfull hbox's. This size/target also enforces
> >>> single column output and increases the size of the pdf
> >>> by almost 40% in terms of number of pages. The actual size
> >>> on the disk is not all that different. The final output
> >>> though is very readable on the kindle I own.
> >>>
> >>> I've been running the command via
> >>>
> >>> env PERFBOOK_PAPER=ER make perfbook-er.pdf
> >>
> >> Do you still need to set PERFBOOK_PAPER? 
> >>
> > 
> > I use it to set PERFBOOK_BASE
> 
> Without setting PERFBOOK_PAPER,
> just "make perfbook-er.pdf" works fine.
> 
> I mean, env PERFBOOK_PAPER=ER make perfbook-1c.pdf
> will generate the same PDF as perfbook-er.pdf would (without
> PERFBOOK_PAPER set).
> 
> Which is mostly the same as perfbook-a4.pdf and perfbook-hb.pdf
> work when PERFBOOK_PAPER=A4 or PERFBOOK_PAPER=HB is specified.
> 
> > 
> >>>
> >>> TODOs:
> >>> 1. Make tables and some figures work nicely in this mode
> >>
> >> Shrinking tables and figures is not so hard, but to shrink tall
> >> code snippets might be tricky.
> >>
> > 
> > The code snippets turned out just fine, the tables had overflows.
> > Even the images are largely fine.
> 
> I see code snippets more than 53 lines are truncated in the -er build.
> 
> >  
> >> I have some ideas to do them.  Can you wait a couple of days?
> >> I'll post some PoC scheme for you to base your further tuning.
> >>
> >> Just shrinking tables and code snippets might result in
> >> illegibly small font, though.
> >>
> > 
> > The code is fine so far, I think with the tables, we might need
> > to find a way for allowing them to cross page boundaries, I have
> > not looked at the table macros yet.
> > 
> > My suggestion is for you to try the patch, see the rendered PDF
> > output and look for artifacts like table 9.1
> 
> I've tested my scheme on top of your patch and applied the
> scheme in cpu, toolsoftrade, cpu, and defer/rcuapi.
> 
> Can you try the patch set I'm sending out soon as replies to this
> message.
> 
> I'm not saying the scheme works for every oversized float types,
> though.
> 
> >  
> >>> 2. Consider scaling the font
> >>
> >> You mean the font size of 10pt is too large for ebook readers?
> >>
> > 
> > I meant largely for tables, the font size on my kindle seems nice.
> 
> I see. My scheme shirks tables as a whole, so some of them might
> become hard to read.
>

Works OK for me so far, it does a tighter packing of tables and
if we shrink the font size, I am sure we can make the tables fit :)

Acked-by: Balbir Singh <bsingharora@gmail.com>

Balbir Singh. 

  parent reply	other threads:[~2021-03-24  7:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  1:01 [RFC PATCH] perfbook/papersize: ebook reader size support Balbir Singh
2021-03-23  5:23 ` Paul E. McKenney
2021-03-23  6:26   ` Balbir Singh
2021-03-23  9:38   ` Balbir Singh
2021-03-23 13:39     ` Akira Yokosawa
2021-03-23 16:10       ` Paul E. McKenney
2021-03-24  1:15       ` Balbir Singh
2021-03-24  2:35         ` Akira Yokosawa
2021-03-24  2:37           ` [RFC PATCH 1/2] perfbook-lt: Add macro to shrink floats for ebook Akira Yokosawa
2021-03-24  2:38           ` [RFC PATCH 2/2] cpu, toolsoftrade, count, rcuapi: Shrink floats for ebook reader Akira Yokosawa
2021-03-24  7:27           ` Balbir Singh [this message]
2021-03-24 14:34             ` [RFC PATCH] perfbook/papersize: ebook reader size support Akira Yokosawa
2021-03-25 10:49 ` [PATCH -perfbook 0/5] " Akira Yokosawa
2021-03-25 10:52   ` [PATCH -perfbook 1/5] perfbook/papersize: " Akira Yokosawa
2021-03-25 10:55   ` [PATCH -perfbook 2/5] perfbook-lt: Add macros to shrink floats for ebook Akira Yokosawa
2021-03-25 10:57   ` [PATCH -perfbook 3/5] cpu, toolsoftrade, count, rcuapi: Shrink floats for ebook reader Akira Yokosawa
2021-03-25 10:58   ` [PATCH -perfbook 4/5] styleguide: Adjust float size and add a floatbarrier for ebook-size build Akira Yokosawa
2021-03-25 11:00   ` [PATCH -perfbook 5/5] Makefile: Add info on ebooksize build in help and help-full Akira Yokosawa
2021-03-26  6:35     ` Balbir Singh
2021-03-26 11:42       ` Akira Yokosawa
2021-03-27 16:33         ` Paul E. McKenney
2021-03-25 11:41   ` [PATCH -perfbook 0/5] ebook reader size support Akira Yokosawa
2021-03-25 16:16   ` Paul E. McKenney
2021-03-25 19:24     ` Akira Yokosawa
2021-03-26  0:12       ` Paul E. McKenney
2021-03-26  0:26         ` Akira Yokosawa
2021-03-26  0:51           ` Paul E. McKenney
2021-03-26  1:08             ` Akira Yokosawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210324072727.GL77072@balbir-desktop \
    --to=bsingharora@gmail.com \
    --cc=akiyks@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox