* [PATCH 0/2] together: Minor fixups
@ 2023-04-29 17:02 SeongJae Park
2023-04-29 17:02 ` [PATCH 1/2] together/refcnt: Use \tco{} for code quoting SeongJae Park
2023-04-29 17:02 ` [PATCH 2/2] together/seqlock: Use term 'sequence lock' consistently SeongJae Park
0 siblings, 2 replies; 9+ messages in thread
From: SeongJae Park @ 2023-04-29 17:02 UTC (permalink / raw)
To: paulmck; +Cc: SeongJae Park, perfbook
From: SeongJae Park <sj38.park@gmail.com>
This patchset contains minor fixups for together/, which found while
doing Korean translation[1].
[1] https://github.com/sjp38/perfbook-ko_KR
SeongJae Park (2):
together/refcnt: Use \tco{} for code quoting
together/seqlock: Use term 'sequence lock' consistently
together/refcnt.tex | 8 ++++----
together/seqlock.tex | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-29 17:02 [PATCH 0/2] together: Minor fixups SeongJae Park @ 2023-04-29 17:02 ` SeongJae Park 2023-04-29 22:20 ` Akira Yokosawa 2023-04-29 17:02 ` [PATCH 2/2] together/seqlock: Use term 'sequence lock' consistently SeongJae Park 1 sibling, 1 reply; 9+ messages in thread From: SeongJae Park @ 2023-04-29 17:02 UTC (permalink / raw) To: paulmck; +Cc: SeongJae Park, perfbook From: SeongJae Park <sj38.park@gmail.com> Some sentences in refcnt.tex is using only quote for some code words. Use \tco{} instead, as it is intended to be used for the case. Signed-off-by: SeongJae Park <sj38.park@gmail.com> --- together/refcnt.tex | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/together/refcnt.tex b/together/refcnt.tex index 56caed67..4abe1c60 100644 --- a/together/refcnt.tex +++ b/together/refcnt.tex @@ -467,15 +467,15 @@ as shown below. \QuickQuiz{ Why can't the check for a zero reference count be - made in a simple ``if'' statement with an atomic - increment in its ``then'' clause? + made in a simple \tco{if} statement with an atomic + increment in its \tco{then} clause? }\QuickQuizAnswer{ - Suppose that the ``if'' condition completed, finding + Suppose that the \tco{if} condition completed, finding the reference counter value equal to one. Suppose that a release operation executes, decrementing the reference counter to zero and therefore starting cleanup operations. - But now the ``then'' clause can increment the counter + But now the \tco{then} clause can increment the counter back to a value of one, allowing the object to be used after it has been cleaned up. -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-29 17:02 ` [PATCH 1/2] together/refcnt: Use \tco{} for code quoting SeongJae Park @ 2023-04-29 22:20 ` Akira Yokosawa 2023-04-29 23:38 ` SeongJae Park 0 siblings, 1 reply; 9+ messages in thread From: Akira Yokosawa @ 2023-04-29 22:20 UTC (permalink / raw) To: SeongJae Park, paulmck; +Cc: SeongJae Park, perfbook Hi, On Sat, 29 Apr 2023 10:02:25 -0700, SeongJae Park wrote: > From: SeongJae Park <sj38.park@gmail.com> > > Some sentences in refcnt.tex is using only quote for some code words. > Use \tco{} instead, as it is intended to be used for the case. \tco{} doesn't put quotes around it. Didn't you mean \qco{} ? Thanks, Akira > > Signed-off-by: SeongJae Park <sj38.park@gmail.com> > --- > together/refcnt.tex | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/together/refcnt.tex b/together/refcnt.tex > index 56caed67..4abe1c60 100644 > --- a/together/refcnt.tex > +++ b/together/refcnt.tex > @@ -467,15 +467,15 @@ as shown below. > > \QuickQuiz{ > Why can't the check for a zero reference count be > - made in a simple ``if'' statement with an atomic > - increment in its ``then'' clause? > + made in a simple \tco{if} statement with an atomic > + increment in its \tco{then} clause? > }\QuickQuizAnswer{ > - Suppose that the ``if'' condition completed, finding > + Suppose that the \tco{if} condition completed, finding > the reference counter value equal to one. > Suppose that a release operation executes, decrementing > the reference counter to zero and therefore starting > cleanup operations. > - But now the ``then'' clause can increment the counter > + But now the \tco{then} clause can increment the counter > back to a value of one, allowing the object to be > used after it has been cleaned up. > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-29 22:20 ` Akira Yokosawa @ 2023-04-29 23:38 ` SeongJae Park 2023-04-30 3:12 ` Akira Yokosawa 0 siblings, 1 reply; 9+ messages in thread From: SeongJae Park @ 2023-04-29 23:38 UTC (permalink / raw) To: Akira Yokosawa; +Cc: SeongJae Park, paulmck, SeongJae Park, perfbook Hi Akira, On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <akiyks@gmail.com> wrote: > Hi, > > On Sat, 29 Apr 2023 10:02:25 -0700, SeongJae Park wrote: > > From: SeongJae Park <sj38.park@gmail.com> > > > > Some sentences in refcnt.tex is using only quote for some code words. > > Use \tco{} instead, as it is intended to be used for the case. > > \tco{} doesn't put quotes around it. > Didn't you mean \qco{} ? You're correct, I was out of my mind. I also mistakenly used an email account that different from what I signed patches off. I will send a new spin tomorrow. Thanks, SJ > > Thanks, Akira > > > > > Signed-off-by: SeongJae Park <sj38.park@gmail.com> > > --- > > together/refcnt.tex | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/together/refcnt.tex b/together/refcnt.tex > > index 56caed67..4abe1c60 100644 > > --- a/together/refcnt.tex > > +++ b/together/refcnt.tex > > @@ -467,15 +467,15 @@ as shown below. > > > > \QuickQuiz{ > > Why can't the check for a zero reference count be > > - made in a simple ``if'' statement with an atomic > > - increment in its ``then'' clause? > > + made in a simple \tco{if} statement with an atomic > > + increment in its \tco{then} clause? > > }\QuickQuizAnswer{ > > - Suppose that the ``if'' condition completed, finding > > + Suppose that the \tco{if} condition completed, finding > > the reference counter value equal to one. > > Suppose that a release operation executes, decrementing > > the reference counter to zero and therefore starting > > cleanup operations. > > - But now the ``then'' clause can increment the counter > > + But now the \tco{then} clause can increment the counter > > back to a value of one, allowing the object to be > > used after it has been cleaned up. > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-29 23:38 ` SeongJae Park @ 2023-04-30 3:12 ` Akira Yokosawa 2023-04-30 3:17 ` Paul E. McKenney 0 siblings, 1 reply; 9+ messages in thread From: Akira Yokosawa @ 2023-04-30 3:12 UTC (permalink / raw) To: SeongJae Park Cc: SeongJae Park, paulmck, perfbook@vger.kernel.org, Akira Yokosawa On Sat, 29 Apr 2023 16:38:12 -0700, SeongJae Park wrote: > Hi Akira, > > On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <akiyks@gmail.com> wrote: > >> Hi, >> >> On Sat, 29 Apr 2023 10:02:25 -0700, SeongJae Park wrote: >>> From: SeongJae Park <sj38.park@gmail.com> >>> >>> Some sentences in refcnt.tex is using only quote for some code words. >>> Use \tco{} instead, as it is intended to be used for the case. >> >> \tco{} doesn't put quotes around it. >> Didn't you mean \qco{} ? > > You're correct, I was out of my mind. I also mistakenly used an email account > that different from what I signed patches off. I will send a new spin > tomorrow. Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca). Can you send a fix on top ? Thanks, Akira > > > Thanks, > SJ > >> >> Thanks, Akira >> >>> >>> Signed-off-by: SeongJae Park <sj38.park@gmail.com> >>> --- >>> together/refcnt.tex | 8 ++++---- >>> 1 file changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/together/refcnt.tex b/together/refcnt.tex >>> index 56caed67..4abe1c60 100644 >>> --- a/together/refcnt.tex >>> +++ b/together/refcnt.tex >>> @@ -467,15 +467,15 @@ as shown below. >>> >>> \QuickQuiz{ >>> Why can't the check for a zero reference count be >>> - made in a simple ``if'' statement with an atomic >>> - increment in its ``then'' clause? >>> + made in a simple \tco{if} statement with an atomic >>> + increment in its \tco{then} clause? >>> }\QuickQuizAnswer{ >>> - Suppose that the ``if'' condition completed, finding >>> + Suppose that the \tco{if} condition completed, finding >>> the reference counter value equal to one. >>> Suppose that a release operation executes, decrementing >>> the reference counter to zero and therefore starting >>> cleanup operations. >>> - But now the ``then'' clause can increment the counter >>> + But now the \tco{then} clause can increment the counter >>> back to a value of one, allowing the object to be >>> used after it has been cleaned up. >>> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-30 3:12 ` Akira Yokosawa @ 2023-04-30 3:17 ` Paul E. McKenney 2023-04-30 21:07 ` SeongJae Park 0 siblings, 1 reply; 9+ messages in thread From: Paul E. McKenney @ 2023-04-30 3:17 UTC (permalink / raw) To: Akira Yokosawa; +Cc: SeongJae Park, SeongJae Park, perfbook@vger.kernel.org On Sun, Apr 30, 2023 at 12:12:24PM +0900, Akira Yokosawa wrote: > On Sat, 29 Apr 2023 16:38:12 -0700, SeongJae Park wrote: > > Hi Akira, > > > > On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <akiyks@gmail.com> wrote: > > > >> Hi, > >> > >> On Sat, 29 Apr 2023 10:02:25 -0700, SeongJae Park wrote: > >>> From: SeongJae Park <sj38.park@gmail.com> > >>> > >>> Some sentences in refcnt.tex is using only quote for some code words. > >>> Use \tco{} instead, as it is intended to be used for the case. > >> > >> \tco{} doesn't put quotes around it. > >> Didn't you mean \qco{} ? > > > > You're correct, I was out of my mind. I also mistakenly used an email account > > that different from what I signed patches off. I will send a new spin > > tomorrow. > > Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca). > > Can you send a fix on top ? Or I can remove that commit if that makes things easier. When you send me the patch, please just let me know if it is to replace 0e96cb8283ca or to go on top of it. Your choice! ;-) And thank you, Akira, for checking. Thanx, Paul > Thanks, Akira > > > > > > > Thanks, > > SJ > > > >> > >> Thanks, Akira > >> > >>> > >>> Signed-off-by: SeongJae Park <sj38.park@gmail.com> > >>> --- > >>> together/refcnt.tex | 8 ++++---- > >>> 1 file changed, 4 insertions(+), 4 deletions(-) > >>> > >>> diff --git a/together/refcnt.tex b/together/refcnt.tex > >>> index 56caed67..4abe1c60 100644 > >>> --- a/together/refcnt.tex > >>> +++ b/together/refcnt.tex > >>> @@ -467,15 +467,15 @@ as shown below. > >>> > >>> \QuickQuiz{ > >>> Why can't the check for a zero reference count be > >>> - made in a simple ``if'' statement with an atomic > >>> - increment in its ``then'' clause? > >>> + made in a simple \tco{if} statement with an atomic > >>> + increment in its \tco{then} clause? > >>> }\QuickQuizAnswer{ > >>> - Suppose that the ``if'' condition completed, finding > >>> + Suppose that the \tco{if} condition completed, finding > >>> the reference counter value equal to one. > >>> Suppose that a release operation executes, decrementing > >>> the reference counter to zero and therefore starting > >>> cleanup operations. > >>> - But now the ``then'' clause can increment the counter > >>> + But now the \tco{then} clause can increment the counter > >>> back to a value of one, allowing the object to be > >>> used after it has been cleaned up. > >>> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-30 3:17 ` Paul E. McKenney @ 2023-04-30 21:07 ` SeongJae Park 2023-04-30 22:51 ` Paul E. McKenney 0 siblings, 1 reply; 9+ messages in thread From: SeongJae Park @ 2023-04-30 21:07 UTC (permalink / raw) To: Paul E. McKenney Cc: Akira Yokosawa, SeongJae Park, SeongJae Park, perfbook@vger.kernel.org Hi Akira and Paul, On Sat, 29 Apr 2023 20:17:25 -0700 "Paul E. McKenney" <paulmck@kernel.org> wrote: > On Sun, Apr 30, 2023 at 12:12:24PM +0900, Akira Yokosawa wrote: > > On Sat, 29 Apr 2023 16:38:12 -0700, SeongJae Park wrote: > > > Hi Akira, > > > > > > On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <akiyks@gmail.com> wrote: > > > > > >> Hi, > > >> > > >> On Sat, 29 Apr 2023 10:02:25 -0700, SeongJae Park wrote: > > >>> From: SeongJae Park <sj38.park@gmail.com> > > >>> > > >>> Some sentences in refcnt.tex is using only quote for some code words. > > >>> Use \tco{} instead, as it is intended to be used for the case. > > >> > > >> \tco{} doesn't put quotes around it. > > >> Didn't you mean \qco{} ? > > > > > > You're correct, I was out of my mind. I also mistakenly used an email account > > > that different from what I signed patches off. I will send a new spin > > > tomorrow. > > > > Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca). > > > > Can you send a fix on top ? > > Or I can remove that commit if that makes things easier. When you send > me the patch, please just let me know if it is to replace 0e96cb8283ca > or to go on top of it. Your choice! ;-) Sorry, I found this mail after I sent the patch. Just for a record. I sent the patch on top of it. If you'd prefer to, please feel free to squash it into the old one. I have no preference but just want to make the trivial nit fixed. > > And thank you, Akira, for checking. Thank you all. Thanks, SJ > > Thanx, Paul > > > Thanks, Akira > > > > > > > > > > > Thanks, > > > SJ > > > > > >> > > >> Thanks, Akira > > >> > > >>> > > >>> Signed-off-by: SeongJae Park <sj38.park@gmail.com> > > >>> --- > > >>> together/refcnt.tex | 8 ++++---- > > >>> 1 file changed, 4 insertions(+), 4 deletions(-) > > >>> > > >>> diff --git a/together/refcnt.tex b/together/refcnt.tex > > >>> index 56caed67..4abe1c60 100644 > > >>> --- a/together/refcnt.tex > > >>> +++ b/together/refcnt.tex > > >>> @@ -467,15 +467,15 @@ as shown below. > > >>> > > >>> \QuickQuiz{ > > >>> Why can't the check for a zero reference count be > > >>> - made in a simple ``if'' statement with an atomic > > >>> - increment in its ``then'' clause? > > >>> + made in a simple \tco{if} statement with an atomic > > >>> + increment in its \tco{then} clause? > > >>> }\QuickQuizAnswer{ > > >>> - Suppose that the ``if'' condition completed, finding > > >>> + Suppose that the \tco{if} condition completed, finding > > >>> the reference counter value equal to one. > > >>> Suppose that a release operation executes, decrementing > > >>> the reference counter to zero and therefore starting > > >>> cleanup operations. > > >>> - But now the ``then'' clause can increment the counter > > >>> + But now the \tco{then} clause can increment the counter > > >>> back to a value of one, allowing the object to be > > >>> used after it has been cleaned up. > > >>> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] together/refcnt: Use \tco{} for code quoting 2023-04-30 21:07 ` SeongJae Park @ 2023-04-30 22:51 ` Paul E. McKenney 0 siblings, 0 replies; 9+ messages in thread From: Paul E. McKenney @ 2023-04-30 22:51 UTC (permalink / raw) To: SeongJae Park; +Cc: Akira Yokosawa, SeongJae Park, perfbook@vger.kernel.org On Sun, Apr 30, 2023 at 02:07:22PM -0700, SeongJae Park wrote: > Hi Akira and Paul, > > On Sat, 29 Apr 2023 20:17:25 -0700 "Paul E. McKenney" <paulmck@kernel.org> wrote: > > > On Sun, Apr 30, 2023 at 12:12:24PM +0900, Akira Yokosawa wrote: > > > On Sat, 29 Apr 2023 16:38:12 -0700, SeongJae Park wrote: > > > > Hi Akira, > > > > > > > > On Sun, 30 Apr 2023 07:20:48 +0900 Akira Yokosawa <akiyks@gmail.com> wrote: > > > > > > > >> Hi, > > > >> > > > >> On Sat, 29 Apr 2023 10:02:25 -0700, SeongJae Park wrote: > > > >>> From: SeongJae Park <sj38.park@gmail.com> > > > >>> > > > >>> Some sentences in refcnt.tex is using only quote for some code words. > > > >>> Use \tco{} instead, as it is intended to be used for the case. > > > >> > > > >> \tco{} doesn't put quotes around it. > > > >> Didn't you mean \qco{} ? > > > > > > > > You're correct, I was out of my mind. I also mistakenly used an email account > > > > that different from what I signed patches off. I will send a new spin > > > > tomorrow. > > > > > > Looks like Paul has already pulled and pushed this (commit 0e96cb8283ca). > > > > > > Can you send a fix on top ? > > > > Or I can remove that commit if that makes things easier. When you send > > me the patch, please just let me know if it is to replace 0e96cb8283ca > > or to go on top of it. Your choice! ;-) > > Sorry, I found this mail after I sent the patch. Just for a record. I sent > the patch on top of it. If you'd prefer to, please feel free to squash it into > the old one. I have no preference but just want to make the trivial nit fixed. And fixed it is! ;-) Thanx, Paul > > And thank you, Akira, for checking. > > Thank you all. > > > Thanks, > SJ > > > > > Thanx, Paul > > > > > Thanks, Akira > > > > > > > > > > > > > > > Thanks, > > > > SJ > > > > > > > >> > > > >> Thanks, Akira > > > >> > > > >>> > > > >>> Signed-off-by: SeongJae Park <sj38.park@gmail.com> > > > >>> --- > > > >>> together/refcnt.tex | 8 ++++---- > > > >>> 1 file changed, 4 insertions(+), 4 deletions(-) > > > >>> > > > >>> diff --git a/together/refcnt.tex b/together/refcnt.tex > > > >>> index 56caed67..4abe1c60 100644 > > > >>> --- a/together/refcnt.tex > > > >>> +++ b/together/refcnt.tex > > > >>> @@ -467,15 +467,15 @@ as shown below. > > > >>> > > > >>> \QuickQuiz{ > > > >>> Why can't the check for a zero reference count be > > > >>> - made in a simple ``if'' statement with an atomic > > > >>> - increment in its ``then'' clause? > > > >>> + made in a simple \tco{if} statement with an atomic > > > >>> + increment in its \tco{then} clause? > > > >>> }\QuickQuizAnswer{ > > > >>> - Suppose that the ``if'' condition completed, finding > > > >>> + Suppose that the \tco{if} condition completed, finding > > > >>> the reference counter value equal to one. > > > >>> Suppose that a release operation executes, decrementing > > > >>> the reference counter to zero and therefore starting > > > >>> cleanup operations. > > > >>> - But now the ``then'' clause can increment the counter > > > >>> + But now the \tco{then} clause can increment the counter > > > >>> back to a value of one, allowing the object to be > > > >>> used after it has been cleaned up. > > > >>> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] together/seqlock: Use term 'sequence lock' consistently 2023-04-29 17:02 [PATCH 0/2] together: Minor fixups SeongJae Park 2023-04-29 17:02 ` [PATCH 1/2] together/refcnt: Use \tco{} for code quoting SeongJae Park @ 2023-04-29 17:02 ` SeongJae Park 1 sibling, 0 replies; 9+ messages in thread From: SeongJae Park @ 2023-04-29 17:02 UTC (permalink / raw) To: paulmck; +Cc: SeongJae Park, perfbook From: SeongJae Park <sj38.park@gmail.com> A sentence in seqlock.tex is calling sequence locks as sequence counters, while all other sentences in the file is calling those sequence locks. Use the term consistently. Signed-off-by: SeongJae Park <sj38.park@gmail.com> --- together/seqlock.tex | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/together/seqlock.tex b/together/seqlock.tex index 5fd31d83..b77b5184 100644 --- a/together/seqlock.tex +++ b/together/seqlock.tex @@ -8,7 +8,7 @@ \epigraph{The girl who can't dance says the band can't play.} {Yiddish proverb} -This section looks at some special uses of sequence counters. +This section looks at some special uses of sequence locks. \subsection{Dueling Sequence Locks} \label{sec:together:Dueling Sequence Locks} -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-04-30 22:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-29 17:02 [PATCH 0/2] together: Minor fixups SeongJae Park
2023-04-29 17:02 ` [PATCH 1/2] together/refcnt: Use \tco{} for code quoting SeongJae Park
2023-04-29 22:20 ` Akira Yokosawa
2023-04-29 23:38 ` SeongJae Park
2023-04-30 3:12 ` Akira Yokosawa
2023-04-30 3:17 ` Paul E. McKenney
2023-04-30 21:07 ` SeongJae Park
2023-04-30 22:51 ` Paul E. McKenney
2023-04-29 17:02 ` [PATCH 2/2] together/seqlock: Use term 'sequence lock' consistently SeongJae Park
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox