Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: "Leonardo Brás" <leobras.c@gmail.com>
To: Akira Yokosawa <akiyks@gmail.com>,
	"Paul E. McKenney" <paulmck@kernel.org>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH -perfbook 8/8] gitlab-ci.yml: Install librsvg instead of inkscape
Date: Fri, 05 Jan 2024 18:39:15 -0300	[thread overview]
Message-ID: <b49648d42bbd646241edbf4b360adb68d7322cb4.camel@gmail.com> (raw)
In-Reply-To: <07aca12c-85f9-4e8c-b0f6-1e502cdd8cc5@gmail.com>

On Fri, 2024-01-05 at 18:58 +0900, Akira Yokosawa wrote:
> On Arch Linux, rsvg-convert is provided in the librsvg package.
> Install it instead of inkscape.
> 
> Using rsvg-convert can shorten runtime of CI job for building PDFs
> a bit.
> 
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> Cc: Leonardo Bras <leobras.c@gmail.com>
> ---

Hello Akira, 

I used the leobras-ci branch from gitlab/linux_kernel/perfbook to test your
patchset: 
https://gitlab.com/linux-kernel/perfbook/-/jobs/5872530547

It generated the pdf successfully, could you check if the images were generated
correctly?
https://gitlab.com/linux-kernel/perfbook/-/jobs/5872530547/artifacts/browse

> Needs an explicit ACK or Tested-by from Leo.
> Expected order of reduction of build time:  ~10s
> 
>  utilities/gitlab-ci.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utilities/gitlab-ci.yml b/utilities/gitlab-ci.yml
> index bcda8712..17525fb4 100644
> --- a/utilities/gitlab-ci.yml
> +++ b/utilities/gitlab-ci.yml
> @@ -19,7 +19,7 @@ generate_pdfs:
>      stage: build
>  
>      before_script:
> -        - pacman --noconfirm -Syu texlive-meta fig2dev ghostscript graphviz inkscape wget make which fontconfig git ttf-dejavu gnu-free-fonts ttf-liberation
> +        - pacman --noconfirm -Syu texlive-meta fig2dev ghostscript graphviz librsvg wget make which fontconfig git ttf-dejavu gnu-free-fonts ttf-liberation

so s/inkscape/librsvg/ right? 

It's fine by me.

Thanks!
Leo

>          - mkdir -p ~/.local/share/fonts && cp fonts/steel-city-comic.regular.ttf ~/.local/share/fonts/ && fc-cache
>  
>      script:


  reply	other threads:[~2024-01-05 21:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05  9:44 [PATCH -perfbook 0/8] Use rsvg-convert for SVG --> PDF conversion Akira Yokosawa
2024-01-05  9:47 ` Akira Yokosawa
2024-01-05  9:50 ` [PATCH -perfbook 2/8] Makefile: Don't use rsvg-convert < 2.57 Akira Yokosawa
2024-01-05  9:52 ` [PATCH -perfbook 3/8] Makefile: Allow rsvg-convert 2.52 Akira Yokosawa
2024-01-05  9:53 ` [PATCH -perfbook 4/8] Makefile: Use rsvg-convert anyway if no inkscape is found Akira Yokosawa
2024-01-05  9:54 ` [PATCH -perfbook 5/8] cartoons: Retouch r-2014-Memory-barrier.svg Akira Yokosawa
2024-01-05  9:55 ` [PATCH -perfbook 6/8] FAQ-BUILD: List package for rsvg-convert in package lists Akira Yokosawa
2024-01-05  9:57 ` [PATCH -perfbook 7/8] docker: Add packages for rsvg-convert Akira Yokosawa
2024-01-05  9:58 ` [PATCH -perfbook 8/8] gitlab-ci.yml: Install librsvg instead of inkscape Akira Yokosawa
2024-01-05 21:39   ` Leonardo Brás [this message]
2024-01-06  1:15     ` Akira Yokosawa
2024-01-06  3:37       ` Leonardo Brás
2024-01-07 21:17         ` Paul E. McKenney
2024-01-05 13:31 ` [PATCH -perfbook 0/8] Use rsvg-convert for SVG --> PDF conversion Paul E. McKenney
2024-01-05 14:51   ` Akira Yokosawa
2024-01-05 15:32     ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b49648d42bbd646241edbf4b360adb68d7322cb4.camel@gmail.com \
    --to=leobras.c@gmail.com \
    --cc=akiyks@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox