Discussions of the Parallel Programming book
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: Kunwu Chan <kunwu.chan@linux.dev>
Cc: Kunwu Chan <kunwu.chan@gmail.com>,
	perfbook@vger.kernel.org, "Paul E. McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] precheck-tentative.sh: Make array.sty probing fail-fast and deterministic
Date: Thu, 7 May 2026 19:37:48 +0900	[thread overview]
Message-ID: <e3237552-6671-434d-a3b9-53a7a5257685@gmail.com> (raw)
In-Reply-To: <20260507095011.1551131-1-kunwu.chan@linux.dev>

Hi,

On Thu,  7 May 2026 17:50:11 +0800, Kunwu Chan wrote:
> On systems where kpsewhich cannot resolve array.sty, the script fed an
> empty path into the version-parsing pipeline and then compared an empty
> array_req_ver against latex_ver in the non-pdflatex-dev path. The
> result depended on environment and produced no actionable error.
> 
> This is reproducible by overriding kpsewhich to return nothing for
> array.sty while keeping other lookups intact.
> 
> Add a guard before parsing array.sty, set array_req_ver only when the
> file exists, fail fast with a clear diagnostic when it does not, and
> correct the warning text typo ("arary.sty" -> "array.sty").
> 
> Fixes: 4cad3dd1174a ("precheck-tentative.sh: Fail early with suggestions for Fedora 44")
> 
> Signed-off-by: Kunwu Chan <kunwu.chan@gmail.com>
> ---
>  utilities/precheck-tentative.sh | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 

I didn't think of running "make" before installing texlive-tools bundle.
That said, this can be helpful in setting up brand new installations.
And thanks for the typo fix!

Acked-by: Akira Yokosawa

Regerds, Akira

> diff --git a/utilities/precheck-tentative.sh b/utilities/precheck-tentative.sh
> index 96d2fe2f..1e106877 100755
[...]

  reply	other threads:[~2026-05-07 10:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  9:50 [PATCH] precheck-tentative.sh: Make array.sty probing fail-fast and deterministic Kunwu Chan
2026-05-07 10:37 ` Akira Yokosawa [this message]
2026-05-07 17:52   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3237552-6671-434d-a3b9-53a7a5257685@gmail.com \
    --to=akiyks@gmail.com \
    --cc=kunwu.chan@gmail.com \
    --cc=kunwu.chan@linux.dev \
    --cc=paulmck@kernel.org \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox