From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yurii Pavlovskyi Subject: [PATCH v2 11/11] platform/x86: asus-wmi: Do not disable keyboard backlight on unload Date: Thu, 11 Apr 2019 07:48:19 +0200 Message-ID: <00efe227-9db9-8709-2de2-d863166c5437@gmail.com> References: <2b130755-87bb-b7a5-939b-4d0ebd69af68@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <2b130755-87bb-b7a5-939b-4d0ebd69af68@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Cc: Corentin Chary , Darren Hart , Andy Shevchenko , Daniel Drake , acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org The keyboard backlight is disabled when module is unloaded as it is exposed as LED device. Change this behavior to ignore setting 0 brightness when the ledclass device is unloading. Signed-off-by: Yurii Pavlovskyi --- drivers/platform/x86/asus-wmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index f0e506feb924..f49992fa87b3 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -475,6 +475,10 @@ static void do_kbd_led_set(struct led_classdev *led_cdev, int value) static void kbd_led_set(struct led_classdev *led_cdev, enum led_brightness value) { + /* Prevent disabling keyboard backlight on module unregister */ + if (led_cdev->flags & LED_UNREGISTERING) + return; + do_kbd_led_set(led_cdev, value); } -- 2.17.1